feat(rich-text-editor): 10 of 10 - add Angular/React wrappers and Storybook docs - #137
Open
derekmoss wants to merge 9 commits into
Open
feat(rich-text-editor): 10 of 10 - add Angular/React wrappers and Storybook docs#137derekmoss wants to merge 9 commits into
derekmoss wants to merge 9 commits into
Conversation
Regenerates Angular and React framework wrappers from the updated custom elements manifest. Adds 11 interactive Storybook stories with full controls coverage for all rich text editor components. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r, and composed views Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…erer index Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
derekmoss
commented
Jun 25, 2026
| part: props.part, | ||
| tabindex: props.tabIndex, | ||
| open: props.open ? true : undefined, | ||
| open: props.open ? "" : undefined, |
Contributor
Author
There was a problem hiding this comment.
I am not sure why these generate to empty strings instead of a boolean.
It looks like an unintended settings. Let me know if we need to revert this.
This reverts commit 420b293.
Contributor
|
derekmoss
marked this pull request as ready for review
June 25, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 10 / 10 Rich Text Editor Version 1.0
PRs are split to provide easily digestible review of the Rich Text Editor
What was added
Adds framework wrappers, Storybook documentation, and the changeset:
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Angular and React wrappers are generated from the core web component definitions. This PR also includes the performance test suite and the final pnpm-lock.yaml update.