feat(breadcrumb): add breadcrumb#1147
Conversation
…stency with other forge components
|
|
🦋 Changeset detectedLatest commit: b182be1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| } | ||
| return html` | ||
| <li class="forge-breadcrumb__crumb-item"> | ||
| <forge-icon-button class="forge-breadcrumb__home-button" aria-label="Home" @click=${this.#handleHomeClick}> |
There was a problem hiding this comment.
This should probably be a link instead of a button, or be configurable. I'd also give some thought to how this might integrate with frameworks. Do we want to try supporting Angular's router? (That's been a goal in our other components)
There was a problem hiding this comment.
The other frameworks was the reason for a button and event over a link. This allows the consumer to tie into the event and handle it however their framework of choice works. Or at least that was my intention. If there is a better way to do that, I am eager to learn that.
| } | ||
|
|
||
| #handleClick(): void { | ||
| this.dispatchEvent( |
There was a problem hiding this comment.
I do kind of wonder whether this event is strictly necessary or if there's a cleaner way to handle interaction
Co-authored-by: Copilot <copilot@github.com>
…ts for that included
…d of requestAnimationFrame
…or-color respectively. Also renamed crumb folder that got missed earlier
3 participants
Summary
Adds the breadcrumb component
Checklist
pnpm changeset)Breaking Changes