Skip to content

add option to exclude unbound numeric ranges #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add option to exclude unbound numeric ranges #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5f8ac2
add option to exclude unbound numeric ranges
anthonybachour May 6, 2024
8c736a5
compare numbers instead of strings
anthonybachour May 7, 2024
9cac080
add builds
anthonybachour May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14,465 changes: 8,063 additions & 6,402 deletions dist/typesense-instantsearch-adapter.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/typesense-instantsearch-adapter.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/typesense-instantsearch-adapter.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/typesense-instantsearch-adapter.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ interface BaseAdapterOptions {
collectionSpecificFilterByOptions?: object;
sortByOptions?: object;
collectionSpecificSortByOptions?: object;
useExcludeForUnboundNumericRange?: boolean;
}

interface CollectionSearchParameters {
Expand Down
4 changes: 3 additions & 1 deletion lib/Configuration.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/Configuration.js.map
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 7 additions & 2 deletions lib/SearchRequestAdapter.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/SearchRequestAdapter.js.map
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/Configuration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export class Configuration {
this.collectionSpecificFacetByOptions = options.collectionSpecificFacetByOptions ?? {};
this.collectionSpecificFilterByOptions = options.collectionSpecificFilterByOptions ?? {};
this.collectionSpecificSortByOptions = options.collectionSpecificSortByOptions ?? {};
this.useExcludeForUnboundNumericRange = options.useExcludeForUnboundNumericRange ?? false;
}

validate() {
Expand Down
9 changes: 7 additions & 2 deletions src/SearchRequestAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,11 +244,16 @@ export class SearchRequestAdapter {
});

// Transform that to:
// "field1:=[634..289] && field2:<=5 && field3:>=3"
// "field1:=[634..289] && field2:<=5 && field3:>=3"
// option to exclude unbound ranges
const adaptedFilters = [];
Object.keys(filtersHash).forEach((field) => {
if (filtersHash[field]["<="] != null && filtersHash[field][">="] != null) {
adaptedFilters.push(`${field}:=[${filtersHash[field][">="]}..${filtersHash[field]["<="]}]`);
if (this.configuration.useExcludeForUnboundNumericRange && parseInt(filtersHash[field][">="]) > parseInt(filtersHash[field]["<="])) {
adaptedFilters.push(`${field}:!=[${filtersHash[field]["<="]}..${filtersHash[field][">="]}]`);
} else {
adaptedFilters.push(`${field}:=[${filtersHash[field][">="]}..${filtersHash[field]["<="]}]`);
}
} else if (filtersHash[field]["<="] != null) {
adaptedFilters.push(`${field}:<=${filtersHash[field]["<="]}`);
} else if (filtersHash[field][">="] != null) {
Expand Down