Skip to content

Conversation

@mcol
Copy link
Contributor

@mcol mcol commented Oct 28, 2025

It's easier to check one commit at a time.

mcol added 8 commits October 16, 2025 09:41
The sample names have been modified to contain the surface coordinates
in the Luminescense example dataset.
When setting several density values in xAsS mode and then switching back
to sAxS mode, the app crashed because it still used all the density values
previously entered instead of just the first. This is a more reliable fix
to tzerk#23.
Copy link
Collaborator

@RLumSK RLumSK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mcol, looks good to me.

@mcol
Copy link
Contributor Author

mcol commented Oct 28, 2025

You'll have to merge, I can't do it :)

@RLumSK RLumSK merged commit b22bcea into tzerk:master Oct 28, 2025
2 checks passed
@RLumSK
Copy link
Collaborator

RLumSK commented Oct 28, 2025

You'll have to merge, I can't do it :)

Sorry, I just wanted to wait for the GA. They had not been finished. Now it is merged.

@mcol mcol deleted the dev_cleanups branch October 28, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants