use precise mask to fix bug for part parse lead frame message error #1867
Closed
gubaojian wants to merge 3 commits intouNetworking:masterfrom
Closed
use precise mask to fix bug for part parse lead frame message error #1867gubaojian wants to merge 3 commits intouNetworking:masterfrom
gubaojian wants to merge 3 commits intouNetworking:masterfrom
Conversation
Contributor
Author
|
` ` |
Contributor
|
std::string two; You need to pre-pad, post-pad your buffer with at least 32 bytes. All parsers in uWS build on relaxed boundary cehcks due to how all buffers are pre and post padded. |
Contributor
Author
thanks for your reply, seems it works well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use precise mask to fix bug for part parse lead frame message error.
here is the test code, you can use the code and the data in zip file to Reproduce the bug :
one_frame.dat.zip
`
`