Change URLs to use id instead of name#130
Open
mebesius wants to merge 7 commits into
Open
Conversation
mebesius
requested review from
DavidW7,
JoshMarangoni,
bfbachmann,
ginsstaahh and
ktabouguia
|
|
||
| def select_by_club_id(session, club_id, user_id, editors_role): | ||
| """ | ||
| Returns returns the membership for the given user of the specified club. |
Contributor
There was a problem hiding this comment.
"Returns" accidentally repeated (line 219)
Contributor
JoshMarangoni
left a comment
JoshMarangoni
left a comment
There was a problem hiding this comment.
Small grammar error in comment, otherwise looks good.
bfbachmann
reviewed
Mar 9, 2019
|
|
||
| from bounce.server.api import util | ||
|
|
||
| test_post_clubs__success_club_identifier = None |
Member
There was a problem hiding this comment.
I think you can remove this line since you don't use this variable anywhere.
Member
|
This looks good, but I'm going to hold off on merging it for now. We'll need to update the front-end to support this, at which point we can merge this PR. |
This was in response to Josh's comment on the PR
In response to Bruno's comment on the PR
…g-URLs-to-use-IDs-over-names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #106
👷 Changes
🚥 Concerns
Will need more refactoring on other endpoints which use club name rather than id, and also the methods which are still using the older club.select() method
🔍 Testing Instructions
Can just run the make docker-test command in terminal