Skip to content
This repository was archived by the owner on Oct 2, 2020. It is now read-only.

Add option to enable TLS - #55

Open
georgeteo wants to merge 2 commits into
masterfrom
enable-tls-option
Open

Add option to enable TLS#55
georgeteo wants to merge 2 commits into
masterfrom
enable-tls-option

Conversation

@georgeteo

Copy link
Copy Markdown
Collaborator

No description provided.

@georgeteo
georgeteo requested a review from mmchen June 7, 2018 17:33
@codecov

codecov Bot commented Jun 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #55 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   72.99%   73.24%   +0.25%     
==========================================
  Files          21       21              
  Lines        1296     1312      +16     
==========================================
+ Hits          946      961      +15     
- Misses        310      311       +1     
  Partials       40       40
Impacted Files Coverage Δ
internal/consumer/options.go 100% <100%> (ø) ⬆️
consumerBuilder.go 81.4% <100%> (+0.18%) ⬆️
consumerOptions.go 72.97% <100%> (+6.3%) ⬆️
internal/consumer/ackMgr.go 83.33% <0%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff86e0...c1a5043. Read the comment docs.

@georgeteo georgeteo mentioned this pull request Jun 7, 2018
@wxing1292 wxing1292 mentioned this pull request May 1, 2019
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants