Skip to content

Conversation

@jeongyoonlee
Copy link
Collaborator

@jeongyoonlee jeongyoonlee commented Dec 7, 2024

Proposed changes

Python 3.7 and 3.8 reached the End-Of-Life (EOL) in 6/2023 and 10/2024, respectively. This PR will drop both versions of Python from the build tests.

Adding Python 3.12 might require removing the Cython version restriction, which needs #803.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@jeongyoonlee jeongyoonlee marked this pull request as ready for review December 7, 2024 03:25
@jeongyoonlee jeongyoonlee merged commit 7169812 into master Dec 7, 2024
8 checks passed
@jeongyoonlee jeongyoonlee deleted the jeong/remove_py37_38 branch December 7, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants