Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses current limitations
mockolofrom working as expected when mocking a protocol whose parent protocol that has a custom name override, e.g. this situation:In such cases,
mockolocurrently fails to recognizeFakeBaseas the parent mock forDerivedProtocol, and thus fails to include the generated implementation fromFakeBasein the body ofDerivedProtocol.The changes in this PR correct that.
All existing unit tests still pass, and I added new unit tests covering the behavior above.
The essential part of the change is explicitly maintaining a map from protocol names to the names of their mocks; it also addresses a few other places where the code implicitly only worked with the default naming pattern.