Implementing typescript support - #2919
Open
sanathusk wants to merge 3 commits into
Open
Conversation
maciek134
approved these changes
Nov 27, 2022
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2919 +/- ##
==========================================
+ Coverage 83.61% 83.84% +0.23%
==========================================
Files 31 32 +1
Lines 1050 1065 +15
==========================================
+ Hits 878 893 +15
Misses 172 172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maciek134
requested changes
Nov 27, 2022
maciek134
reviewed
Nov 27, 2022
maciek134
reviewed
Nov 27, 2022
NeoTheThird
reviewed
Nov 28, 2022
NeoTheThird
left a comment
NeoTheThird
left a comment
Member
There was a problem hiding this comment.
Take a look at @maciek134's requests, then it looks good!
sanathusk
requested review from
NeoTheThird and
maciek134
and removed request for
maciek134
November 29, 2022 14:42
maciek134
approved these changes
Nov 29, 2022
Flohack74
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR includes that allow typescript support in svelte components.