-
Notifications
You must be signed in to change notification settings - Fork 0
Humble virtual image #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: artivis <[email protected]>
Signed-off-by: artivis <[email protected]>
Signed-off-by: artivis <[email protected]>
| @@ -0,0 +1,15 @@ | |||
| language: minimal | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need a travis.yaml file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gadget is a copy/paste of the Core22 pc-gadget. I only modified what was needed and left the rest as is.
| @@ -0,0 +1,34 @@ | |||
| # 64bit PC Gadget Snap | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generic file to remove or update.
| @@ -0,0 +1,62 @@ | |||
| volumes: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this file duplicated in turtlebot3c-gadget/gadget and in turtlebot3c-gadget/?
| @@ -0,0 +1,15 @@ | |||
| all: mbr.img | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is legacy bios used when booting an image with LXD?
| @@ -0,0 +1,109 @@ | |||
| # The recovery partition | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this belongs here since it's a generic information about ubuntu core image?
| @@ -0,0 +1,23 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # This file is included for reference purposes. If MODEL_APIKEY is not set | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MODEL_APIKEY is not set here so this file has no purpose here.
| export CROSS_COMPILE= | ||
| # Set some variables that depend on the architecture | ||
| grub_target=x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be compatible with the arm64 gadget that was added?
Signed-off-by: artivis <[email protected]>
Signed-off-by: artivis <[email protected]>
No description provided.