Skip to content

Conversation

@artivis
Copy link
Contributor

@artivis artivis commented Sep 30, 2024

No description provided.

@artivis artivis marked this pull request as ready for review September 30, 2024 12:50
@@ -0,0 +1,15 @@
language: minimal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need a travis.yaml file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gadget is a copy/paste of the Core22 pc-gadget. I only modified what was needed and left the rest as is.

@@ -0,0 +1,34 @@
# 64bit PC Gadget Snap
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generic file to remove or update.

@@ -0,0 +1,62 @@
volumes:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this file duplicated in turtlebot3c-gadget/gadget and in turtlebot3c-gadget/?

@@ -0,0 +1,15 @@
all: mbr.img
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is legacy bios used when booting an image with LXD?

@@ -0,0 +1,109 @@
# The recovery partition
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this belongs here since it's a generic information about ubuntu core image?

@@ -0,0 +1,23 @@
#!/bin/sh

# This file is included for reference purposes. If MODEL_APIKEY is not set
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MODEL_APIKEY is not set here so this file has no purpose here.

export CROSS_COMPILE=
# Set some variables that depend on the architecture
grub_target=x86_64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be compatible with the arm64 gadget that was added?

Signed-off-by: artivis <[email protected]>
Signed-off-by: artivis <[email protected]>
@artivis artivis merged commit 6774948 into humble-virtual Oct 1, 2024
4 checks passed
@artivis artivis deleted the feat/humble-virtual branch October 1, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants