-
Notifications
You must be signed in to change notification settings - Fork 27
Add Gen3 Workflow cli and tool. #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
paulineribeyre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but i'm hoping we can find a way to forward all the command arguments to nextflow. Meaning that whatever text is after gen3 workflow would be forwarded to nextflow directly. Not all nextflow commands start with "run", we shouldn't hardcode it.
For example: gen3 workflow -C my.config run workflow.nf should call nextflow -C my.config run workflow.nf
As an added bonus, this would make this tool generic - you could run gen3 workflow --workflow-agent python script.py and it would run python script.py.
If you get this to work, we could rename the tool so it's truly generic: gen3 wrap <command> <arguments> to run the command with a GEN3_TOKEN env var 🎉
Please make sure to include documentation on the generic usage (if relevant) and the nextflow usage (such as using $GEN3_TOKEN in the config)
|
If we were to achieve the gen3 wrap functionality, in order to run a nextflow workflow say on "main.nf", do we do,
Since, having |
|
@nss10 In that case i think there shouldn't be a default |
paulineribeyre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, minor comments
Link to JIRA ticket if there is one: MIDRC-892
New Features
gen3 runthat relays any command sent to it by addingGEN3_TOKENenv var.