Skip to content

Conversation

@nss10
Copy link
Contributor

@nss10 nss10 commented Nov 23, 2024

Link to JIRA ticket if there is one: MIDRC-892

New Features

  • Adding Gen3 Wrapper command gen3 run that relays any command sent to it by adding GEN3_TOKEN env var.

@nss10 nss10 requested a review from paulineribeyre November 23, 2024 22:43
@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@nss10 nss10 changed the title Add cli and tool logic Add Gen3 Workflow cli and tool. Nov 23, 2024
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but i'm hoping we can find a way to forward all the command arguments to nextflow. Meaning that whatever text is after gen3 workflow would be forwarded to nextflow directly. Not all nextflow commands start with "run", we shouldn't hardcode it.

For example: gen3 workflow -C my.config run workflow.nf should call nextflow -C my.config run workflow.nf

As an added bonus, this would make this tool generic - you could run gen3 workflow --workflow-agent python script.py and it would run python script.py.

If you get this to work, we could rename the tool so it's truly generic: gen3 wrap <command> <arguments> to run the command with a GEN3_TOKEN env var 🎉

Please make sure to include documentation on the generic usage (if relevant) and the nextflow usage (such as using $GEN3_TOKEN in the config)

@nss10
Copy link
Contributor Author

nss10 commented Nov 27, 2024

If we were to achieve the gen3 wrap functionality, in order to run a nextflow workflow say on "main.nf", do we do,

gen3 wrap workflow run main.nf

Since, having nextflow as the default workflow-agent for a generic function doesn't totally make sense.

@paulineribeyre
Copy link
Contributor

@nss10 In that case i think there shouldn't be a default

@nss10 nss10 requested a review from paulineribeyre December 3, 2024 20:09
@nss10 nss10 requested a review from paulineribeyre December 5, 2024 20:52
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, minor comments

@nss10 nss10 requested a review from paulineribeyre December 11, 2024 15:48
@nss10 nss10 merged commit 1091867 into master Dec 11, 2024
8 checks passed
@nss10 nss10 deleted the feat/gen3workflow branch December 11, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants