refactor(fs-bridge, ucd-store): add basePath to operations #300
Conversation
…operations * Updated `read`, `write`, `listdir`, `mkdir`, `exists`, and `rm` methods to include `basePath` parameter. * This change improves the flexibility of file operations by allowing base path resolution.
* Removed unnecessary basePath option from `vscodeFSBridge` setup. * Updated methods to accept basePath as a parameter instead of relying on the bridge's options. * Improved clarity and consistency in file operations.
* Updated `read`, `exists`, `listdir`, `mkdir`, `rm`, and `write` methods to accept `basePath` as a parameter. * Ensured consistent path resolution across both HTTP and Node file system bridges. * Removed unnecessary basePath option from `createNodeUCDStore` function.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
pkg: ucd-store
🌏 Preview Deployments
Built from commit: 🤖 This comment will be updated automatically when you push new commits to this PR. |
luxass
changed the title
* Removed redundant `basePath` parameter from `NodeFileSystemBridge`. * Updated file system operations to consistently use `basePath` for path resolution. * Improved clarity and maintainability of the code by ensuring all file operations reference the correct base path.
* Removed unnecessary `basePath` usage in file path joins across `clean`, `mirror`, and `repair` functions. * Updated tests to reflect changes in file path handling, ensuring consistency in file system operations. * Improved readability and maintainability of the codebase by streamlining path management.
1 participant
🔗 Linked issue
resolves #299
📚 Description