Skip to content

chore: adopt strict Ultracite and Effect linting - #603

Merged
ueberBrot merged 1 commit into
mainfrom
chore/ultracite-effect-lint
Oct 9, 2026
Merged

ueberBrot merged 1 commit into
mainfrom
chore/ultracite-effect-lint

Conversation

@ueberBrot

Copy link
Copy Markdown
Owner

Summary

Adopt Ultracite core, React, TanStack, Vitest and anti-slop presets plus Effect strict. Refactor the Scheduler, Management Surface, Management Adapters, Dashboard and tests to satisfy them, preserving public synchronous and Promise contracts. Keep compatibility exceptions scoped to existing public error contracts and supported test APIs.

 CI
- default lint → builds → separate type checks and typed lint
+ fast lint → builds → combined typed lint/typecheck → Astro check

Restore fmt:fix and fmt:check, declare Shoehorn in its five consuming workspaces, and declare Zod in docs. Includes cleanup of obsolete docs evidence images.

Evidence

  • Before: Applying the initial strict presets exposed 5,663 lint errors and 440 warnings.
    After: The final configuration reports zero diagnostics across 407 files and 738 rules. Fast lint, Effect lint, formatting and Astro checks also pass.
  • Tests: 1,622 tests across 127 files pass with none pending; all 420 Playwright E2E tests pass across desktop/mobile and authenticated variants.
  • Packages: All six package builds, publint and attw pass; Dashboard development and docs builds pass.
  • Public API: Exported declaration comparison against main reports zero differences. Packed-consumer scenarios minimum-core, minimum-management and current pass.

Merge Danger

Door: two-way

Revert the commit to restore the previous implementation and tooling.

Blast Radius: workspace

Broad refactors touch Scheduler behavior, Management Adapters and Dashboard. Passing runtime and consumer checks support compatibility; declaration equality verifies the exported type contracts.

@changeset-bot

changeset-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3155cae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ueberBrot
ueberBrot enabled auto-merge (squash) October 9, 2026 14:52
@ueberBrot
ueberBrot merged commit 7753654 into main Oct 9, 2026
11 checks passed
@ueberBrot
ueberBrot deleted the chore/ultracite-effect-lint branch October 9, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant