Repository navigation
chore: adopt strict Ultracite and Effect linting - #603
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopt Ultracite core, React, TanStack, Vitest and anti-slop presets plus Effect strict. Refactor the Scheduler, Management Surface, Management Adapters, Dashboard and tests to satisfy them, preserving public synchronous and Promise contracts. Keep compatibility exceptions scoped to existing public error contracts and supported test APIs.
Restore
fmt:fixandfmt:check, declare Shoehorn in its five consuming workspaces, and declare Zod in docs. Includes cleanup of obsolete docs evidence images.Evidence
After: The final configuration reports zero diagnostics across 407 files and 738 rules. Fast lint, Effect lint, formatting and Astro checks also pass.
publintandattwpass; Dashboard development and docs builds pass.mainreports zero differences. Packed-consumer scenariosminimum-core,minimum-managementandcurrentpass.Merge Danger
Door: two-way
Revert the commit to restore the previous implementation and tooling.
Blast Radius: workspace
Broad refactors touch Scheduler behavior, Management Adapters and Dashboard. Passing runtime and consumer checks support compatibility; declaration equality verifies the exported type contracts.