Skip to content

Conversation

@siamahnaf
Copy link

Changes Overview

Current version has following code on extension-drag-handle/src/helpers/dragHandler.ts-

const $from = doc.resolve(result.pos)
const $to = doc.resolve(result.pos + result.resultNode.nodeSize)

And I changed to

const $from = doc.resolve(result.pos)
const $to = doc.resolve(result.pos + 1)

Implementation Approach

I do following steps-

  • Very first tried to reproduce the error on tiptap repository code, I find out the error still happening on there also
Screenshot 2026-02-07 at 1 28 17 PM
  • Then search previous version code where nested options was not introduced like v3.16.0. And on that previous version the line was const $to = doc.resolve(result.pos + 1).
  • Then I change only const $to = doc.resolve(result.pos + result.resultNode.nodeSize) to const $to = doc.resolve(result.pos + 1)
  • I checked and it get solved

Testing Done

Testing done on tiptap repository demos.

Verification Steps

Just the review the changes, its one line code change only.

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

#7508

@netlify
Copy link

netlify bot commented Feb 7, 2026

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit b22a115
🔍 Latest deploy log https://app.netlify.com/projects/tiptap-embed/deploys/6986ecf25649f800080e7ce1
😎 Deploy Preview https://deploy-preview-7509--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2026

⚠️ No Changeset found

Latest commit: b22a115

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant