First datagrid ".header-cell" can select all rows only

[Vlczech]

Currently, all of ".header-cell"-s select all rows, which is not so practical and not intuitive/user-friendly if user click accidentally outside sort link or sort control button (but I hope, that it is only a bug of bad selector (".headel-cell" instead of ".header-cell:first-of-type" or wrongly placed of first() function ).

Second one was selected as a fix, because usage of .first() is needed in the firstly mentioned possible fix also.

[uestla]

It's actually a feature - see tooltips at http://twigrid.1991.cz/group-actions
first() is used to append the "virtual" checkbox to first header cell.

However, I'm planning on changing this behavior. There will be two checkboxes above the table like "select visible" and "select all" and the checking via clicking on header will be removed.

[Vlczech]

OK, I was surprised, when I clicked on header accidentally and all rows were selected - this was unexpected behavior for me. In my eyes it was a bug, which led me to do this pull request :) However, for me it is more a bug than a feature. If i would like to select all, I click first column. As a feature I don't see any benefit (except a shortcut for lazy mouse shifters) and it does not make sense for me.

It would be better, if should be sort link displayed as block through whole table cell - for better navigation in cell phones and tablets.

[uestla]

I see. I kind of like the block sorting buttons, the thing is how to deal with multisort "+" buttons then?

[Vlczech]

There are many options:

1. sort-link as block with margin-left to "+" button
2. some checkbox or radiobox (for example above the table) to change behavior between single sort and multi sort
3. single sort by default, multisort by click with holding "ctrl" as when selecting each file in OS.
4. ..maybe other solutions?

---

BTW: there is a strange behavior of multisorting => #28