Skip to content

Add windows-11-arm to build matrix#225

Merged
uhop merged 3 commits into
uhop:masterfrom
saschanaz:win-arm64
May 2, 2025
Merged

Add windows-11-arm to build matrix#225
uhop merged 3 commits into
uhop:masterfrom
saschanaz:win-arm64

Conversation

@saschanaz
Copy link
Copy Markdown
Contributor

Fixes #224

@saschanaz
Copy link
Copy Markdown
Contributor Author

This is the result of the release CI: https://github.com/saschanaz/node-re2/releases/tag/v1.21.4.1

@uhop uhop self-assigned this May 1, 2025
@uhop uhop self-requested a review May 1, 2025 19:59
Copy link
Copy Markdown
Owner

@uhop uhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uhop
Copy link
Copy Markdown
Owner

uhop commented May 1, 2025

But tests should not include different processors, only different OSes. I can change it back myself when merging later.

@saschanaz
Copy link
Copy Markdown
Contributor Author

I thought having test could skip (or help at least) this part:

When this feature is implemented volunteers will be needed to test it.

But I can roll it back.

@uhop
Copy link
Copy Markdown
Owner

uhop commented May 1, 2025

Yes, it definitely proved that it works, thank you.

@uhop uhop merged commit de0d758 into uhop:master May 2, 2025
9 checks passed
@saschanaz saschanaz deleted the win-arm64 branch May 2, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Windows ARM64 build

2 participants