Remove default title escape in playerctl module #2294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originall saw the need for escaping titles because I had pango set to markup in my bar config. However, removing that removes the need for escaping. If users still use pango markup in their bar config, they can add the escape themselves in the format_player. Therefore, this is potentially a breaking change for some users. This specifically was found when the escape translated an ampersand (&) to &, which then showed up in the title. I also had a `max_length` in the format_player. When the max length cut off right in the middle of the escaped sequence, the bar would not show any output.
|
The CI fails (specifically, |
lasers
approved these changes
Oct 27, 2025
Fixed the CI build: #2295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originall saw the need for escaping titles because I had pango set to markup in my bar config. However, removing that removes the need for escaping. If users still use pango markup in their bar config, they can add the escape themselves in the format_player. This is a breaking change for users who use the pango markup for this module without having the escape in their format.
This specifically was found annoying when the escape translated an ampersand (
&) to&, which then showed up in the title. I also had amax_lengthin the format_player. When the max length cut off right in the middle of the escaped sequence, the bar would not show any output.