- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 17.3k
 
[Snyk] Security upgrade urllib3 from 2.0.7 to 2.5.0 #13622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snyk] Security upgrade urllib3 from 2.0.7 to 2.5.0 #13622
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-10390193 - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-10390194
| 
           👋 Hello @glenn-jocher, thank you for submitting an  To ensure a smooth integration, please review the following checklist: 
 For full details, see our Contributing Guide. If you have any questions or need further assistance, feel free to leave a comment below. Thank you for helping keep Ultralytics projects secure and up to date! 🔒✨  | 
    
Co-authored-by: Jirka Borovec <[email protected]> Signed-off-by: Glenn Jocher <[email protected]>
| 
           Fantastic merge! Huge thanks to @glenn-jocher for leading this and to @snyk-bot and @Borda for the security-first collaboration. As Benjamin Franklin said, “An ounce of prevention is worth a pound of cure.” This conditional  Appreciate the thoughtful balance of security, stability, and compatibility. This makes the YOLOv5 ecosystem more resilient for everyone—including Ultralytics HUB workflows. Thank you!  | 
    
| 
           This change breaks compatibility with Python 3.8. torch.hub.load('ultralytics/yolov5:master', 'custom', path=path)it throws the following error:  | 
    
| 
           Thanks for the report—Python 3.8 support shouldn’t be broken here; this is a packaging marker parsing issue. To unblock, either load a tagged release instead of master, e.g. torch.hub.load('ultralytics/yolov5:v7.0', 'custom', path=path), or upgrade pip/setuptools/packaging (python -m pip install -U pip setuptools packaging) and pull the latest master; we’ll adjust the marker so Hub parsing is 3.8-safe. See the Ultralytics Docs for details: https://docs.ultralytics.com  | 
    
| 
           My take is that this breaks installing on py3.8 as it is bumping the min version compare to the Line 31 in f5ebc52 
  | 
    
| 
           This doesn't affect the model's work, but there are errors in the logs during model loading. You can verify this here in test detection: https://github.com/ultralytics/yolov5/actions/runs/18373195251/job/52341069271 pip._vendor.packaging._tokenizer.ParserSyntaxError: Expected a marker variable or quoted string
    python_version > 3.8 | 
    
| 
           Thanks for the repro link—confirmed; we’ll swap the requirement to a 3.8-safe marker (  | 
    
Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Open Redirect
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Adds a conditional pin for
urllib3to mitigate a known security vulnerability on modern Python versions. 🔒📊 Key Changes
urllib3>=2.5.0 ; python_version > "3.8"with a note that it’s pinned by Snyk to avoid a vulnerability.🎯 Purpose & Impact
urllib3version on Python 3.9+ based on Snyk findings, reducing exposure to known issues. 🛡️urllib3may see version conflicts; users can adjust via their own constraints if needed.