Added rate limiting evaluation window - #131
Open
ezafeire wants to merge 1 commit into
Open
Conversation
Added the ability to define an evaluation window when creating a rate_based_statement in a rule.
dmzeus
approved these changes
Apr 15, 2024
|
It's a minor change but much needed) |
stavbernazport
approved these changes
Apr 15, 2024
|
This is very needed!! |
|
@splichy Can you please check if this can be released? |
|
Any news here?) |
|
Any update on this PR please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to define an evaluation window when creating a rate_based_statement in a rule.
Description
While implementing rate limit policies on WAF for a client, I realized that there was no way to lower the evaluation window that WAF uses to determine rate limiting requests to under 300 sec.
With this PR you can modify it and if you don't it defaults to 300 sec (the default 5 minutes).