Updated Version check and minor cleanup #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Version Check
Recently used the API within a modified version of wave-amp and noticed the program wasn't working within newer versions of CC: Tweaked (version 1.100.1 in my case). Due to an under sight within the API, I realized that it was running into issues because it was unable to properly process triple-digit version numbers. I have made a fix within the program that should be able to handle any number of digits
Cleanup
Saw a single line with leading white space and got rid of it
Other Thoughts
I saw the edit within the copyright from a previous commit and I was thinking, maybe a contribution file could be made? I have updated the copyright year to stay uniform, however, I feel it would be more accurate to copyright each contributors' work. Don't know many details regarding copyright, although I feel this should be brought up eventually with more people contributing