[UNDERTOW-2736] Align handlers$Builder pattern#1934
Open
baranowb wants to merge 1 commit intoundertow-io:mainfrom
Open
[UNDERTOW-2736] Align handlers$Builder pattern#1934baranowb wants to merge 1 commit intoundertow-io:mainfrom
baranowb wants to merge 1 commit intoundertow-io:mainfrom
Conversation
baranowb
added
enhancement
Contributor
Author
|
As is it does not remove old classes, but removes them from services def, as it cause duplicates. |
ropalka
approved these changes
Mar 10, 2026
Member
|
Are any of these in a released version of Undertow? If not, just moving the builders. If they're only in main, at least AFAIK, we don't have backwards compatibility to worry about. However, if they're in a released version of Undertow than we do need to deprecate them. That said, we should add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/UNDERTOW-2736