Skip to content

feat: cargo install astrid installs both CLI and daemon#613

Merged
joshuajbouw merged 1 commit intomainfrom
feat/cargo-install
Mar 24, 2026
Merged

feat: cargo install astrid installs both CLI and daemon#613
joshuajbouw merged 1 commit intomainfrom
feat/cargo-install

Conversation

@joshuajbouw
Copy link
Contributor

Linked Issue

Closes #612

Summary

cargo install astrid now installs both astrid (CLI) and astrid-daemon binaries from the single astrid crate. The daemon entry point is added as a second [[bin]] in the CLI crate's Cargo.toml.

Changes

  • Added [[bin]] name = "astrid-daemon" path = "src/daemon.rs" to CLI crate
  • Added astrid-kernel dependency to CLI crate
  • Added signal feature to workspace tokio (daemon needs it for SIGTERM)
  • src/daemon.rs is a copy of the standalone daemon's main.rs
  • Standalone astrid-daemon crate unchanged (workspace development)

Test Plan

Automated

  • cargo test --workspace passes
  • No new clippy warnings

Manual

  • cargo build -p astrid produces both target/release/astrid and target/release/astrid-daemon

Checklist

  • Linked to an issue
  • CHANGELOG.md updated under [Unreleased]

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the installation of the Astrid application by consolidating the astrid CLI and astrid-daemon into a single cargo install astrid command. This change simplifies the user experience by ensuring both essential components are installed together, making the setup process more straightforward and reducing potential configuration issues.

Highlights

  • Unified Installation: The cargo install astrid command now installs both the astrid CLI and astrid-daemon binaries from a single crate, simplifying the installation process.
  • Daemon Integration: The astrid-daemon entry point has been added as a second [[bin]] target within the astrid-cli crate's Cargo.toml, consolidating the daemon's build within the CLI project.
  • Dependency Management: The astrid-kernel dependency was added to the astrid-cli crate, and the signal feature was enabled for the tokio dependency at the workspace level to support daemon signal handling.
  • Source Relocation: The daemon's main source code, previously in the standalone astrid-daemon crate, has been copied into src/daemon.rs within the astrid-cli crate to facilitate the unified build.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.


One command now serves, CLI and daemon unite, Simpler setup blooms.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to simplify installation by packaging both the astrid CLI and astrid-daemon into a single crate installable via cargo install. This is achieved by adding a second binary target to the astrid crate, with its source being a copy of the standalone daemon's entry point. While this approach is functional, it introduces significant code duplication. My review focuses on this key maintainability issue and proposes a refactoring to share the daemon logic from a library crate, thereby eliminating the duplicated code.

Add astrid-daemon as a second [[bin]] entry point in the astrid (CLI)
crate. `cargo install astrid` now installs both binaries. The standalone
astrid-daemon crate stays for workspace development.

Also adds tokio signal feature to workspace deps (needed by daemon).

Closes #612
@joshuajbouw joshuajbouw merged commit 44b788b into main Mar 24, 2026
13 checks passed
@joshuajbouw joshuajbouw deleted the feat/cargo-install branch March 24, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: cargo install astrid installs both CLI and daemon binaries

1 participant