Skip to content

Conversation

@roubert
Copy link
Member

@roubert roubert commented Dec 10, 2025

https://groups.google.com/a/unicode.org/g/icu-support/c/61hEq3foH7o

Checklist

  • Required: Issue filed: ICU-23247
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

@roubert roubert marked this pull request as ready for review December 10, 2025 09:08
@roubert roubert requested a review from mihnita December 10, 2025 09:08
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait

@markusicu
Copy link
Member

@roubert we like your change, but we also think we should then cherry-pick it onto the maint/maint-78 branch. For that, please create a separate ticket, so that we can more cleanly mark that ticket for 78.2+79.1, and update this PR.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@roubert roubert changed the title ICU-23247 Remove attribute 'dllexport' from deleted functions ICU-23293 Remove attribute 'dllexport' from deleted functions Dec 12, 2025
@roubert
Copy link
Member Author

roubert commented Dec 12, 2025

For that, please create a separate ticket, so that we can more cleanly mark that ticket for 78.2+79.1, and update this PR.

https://unicode-org.atlassian.net/browse/ICU-23293

@markusicu markusicu merged commit 022b44e into unicode-org:main Dec 12, 2025
97 checks passed
@markusicu
Copy link
Member

Hi @roubert can you please cherry-pick this onto the maint/maint-78 branch? If not, I can ask @echeran to do so.

@roubert
Copy link
Member Author

roubert commented Dec 12, 2025

Hi @roubert can you please cherry-pick this onto the maint/maint-78 branch?

PR #3798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants