Skip to content

Conversation

@eggrobin
Copy link
Member

@eggrobin eggrobin commented Dec 29, 2025

Also include it in string-element: https://www.unicode.org/reports/tr61/#string-element.

Checklist

  • Required: Issue filed: ICU-22851
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

@eggrobin eggrobin force-pushed the named-element-is-an-element branch from 2f5d136 to 1d3fcf6 Compare December 29, 2025 19:26
@jira-pull-request-webhook

This comment was marked as outdated.

@eggrobin eggrobin force-pushed the named-element-is-an-element branch from 1d3fcf6 to 2f5d136 Compare December 29, 2025 19:27
@jira-pull-request-webhook

This comment was marked as off-topic.

@eggrobin eggrobin force-pushed the named-element-is-an-element branch from 69ded58 to 68322f0 Compare December 29, 2025 20:34
@jira-pull-request-webhook

This comment was marked as resolved.

@eggrobin eggrobin marked this pull request as ready for review December 29, 2025 20:35
return nullptr;
}
if (category_ == PROPERTY_QUERY || category_ == NAMED_ELEMENT || category_ == VARIABLE) {
if (category_ == PROPERTY_QUERY || category_ == VARIABLE) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "named-element" from the preceding comment

// caused the syntax to be preserved. Now it is treated like an escape.
{uR"([ \N{LATIN CAPITAL LETTER Z}eichenmenge ])", uR"([Zceg-imn])"},
// This was ill-formed in ICU 78 and earlier (in a convoluted way:
// {\N{LATIN CAPITAL LETTER Z} was a well-formed string literal, but then the second }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean

Suggested change
// {\N{LATIN CAPITAL LETTER Z} was a well-formed string literal, but then the second }
// {\N{LATIN CAPITAL LETTER Z}} was a well-formed string literal, but then the second }

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not. {\N{LATIN CAPITAL LETTER Z} was a well-formed string literal whose value was N{LATINCAPITALLETTERZ.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but there is no “second }” to be unpaired, so I don't understand the second part of the sentence.

Copy link
Member Author

@eggrobin eggrobin Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a second } in {\N{LATIN CAPITAL LETTER Z}eichenkette}.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it now -- there is no second } in the comment, but there is in the test case... nvm

@eggrobin eggrobin force-pushed the named-element-is-an-element branch from 63e49f5 to 17f175d Compare December 29, 2025 22:22
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@eggrobin eggrobin merged commit 27b8fb1 into unicode-org:main Dec 29, 2025
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants