-
-
Notifications
You must be signed in to change notification settings - Fork 862
ICU-22851 A named-element is an element, not a set #3828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22851 A named-element is an element, not a set #3828
Conversation
2f5d136 to
1d3fcf6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1d3fcf6 to
2f5d136
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
69ded58 to
68322f0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
| return nullptr; | ||
| } | ||
| if (category_ == PROPERTY_QUERY || category_ == NAMED_ELEMENT || category_ == VARIABLE) { | ||
| if (category_ == PROPERTY_QUERY || category_ == VARIABLE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "named-element" from the preceding comment
| // caused the syntax to be preserved. Now it is treated like an escape. | ||
| {uR"([ \N{LATIN CAPITAL LETTER Z}eichenmenge ])", uR"([Zceg-imn])"}, | ||
| // This was ill-formed in ICU 78 and earlier (in a convoluted way: | ||
| // {\N{LATIN CAPITAL LETTER Z} was a well-formed string literal, but then the second } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean
| // {\N{LATIN CAPITAL LETTER Z} was a well-formed string literal, but then the second } | |
| // {\N{LATIN CAPITAL LETTER Z}} was a well-formed string literal, but then the second } |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not. {\N{LATIN CAPITAL LETTER Z} was a well-formed string literal whose value was N{LATINCAPITALLETTERZ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but there is no “second }” to be unpaired, so I don't understand the second part of the sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a second } in {\N{LATIN CAPITAL LETTER Z}eichenkette}.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get it now -- there is no second } in the comment, but there is in the test case... nvm
63e49f5 to
17f175d
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Also include it in string-element: https://www.unicode.org/reports/tr61/#string-element.
Checklist