-
Notifications
You must be signed in to change notification settings - Fork 220
Add Indic_Conjunct_Break property. #6379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After fixing https://unicode-org.atlassian.net/browse/ICU-23092 / unicode-org/icu#3457, icuexport will export valid value for Indic_Conjunct_Break. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm
Given that this doesn't have names and is a draft property, should we make this doc(hidden)
for now until it has names? This is only needed internally for segmenter, so we don't have to commit to the property enum just yet if we don't want to.
We can remove names from the API. I'm happy to expose this as a stable (nameless) property. |
Does it mean that we can remove parse, short name and long name? |
I think that would be the best option for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also cc @sffc for doc(hidden)
From #6367, @eggrobin suggests to use Indic_Conjunct_Break (InCB) property for Grapheme Cluster Break.
Also,
InCB.toml
is incomplete yet like the following, since it is added by ICU76 as a draft API.It means that names (short / long / parse) are empty for this implementation.