ci: Add unit testing for wasm variant #14

jeromelaban · 2026-01-13T16:38:06Z

No description provided.

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

This PR adds comprehensive unit testing for the WebAssembly variant of the unoicu library. It introduces a validation framework that tests the compiled unoicu.a artifacts using headless Chromium via Puppeteer to ensure the ICU library functions correctly in a browser environment.

Changes:

Added validation test harness (C program and JavaScript test runner) to validate unoicu.a artifacts
Expanded CI build matrix to include multithreaded and SIMD variants (4 combinations: mt/st × simd/nosimd)
Enhanced Dockerfile with cross-compilation support and build configuration for threading/SIMD
Added new validate_unoicu job in CI pipeline to test artifacts before packaging

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/unoicu/validation/run-test.js	New Puppeteer-based test runner that launches headless Chrome to validate the WASM module
src/unoicu/validation/main.c	New C test harness that exercises ICU string conversion functions and reports results to JavaScript
src/unoicu/validation/README.md	Documentation explaining the validation harness and its purpose
src/unoicu/Dockerfile	Enhanced with cross-compilation support, pkgdata patch, multithreading/SIMD build arguments, and typo fix ("currect" → "current")
.github/workflows/main.yml	Expanded build matrix, added validate_unoicu job, updated artifact handling to support multiple configurations, and added package job dependency on validation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T16:41:27Z

.github/workflows/main.yml

+          shopt -s nullglob
          for dir in unoicu-*; do
-            new_name="${dir#unoicu-}"
-            mkdir -p ../nuget/uno.icu-wasm/buildTransitive/native/unoicu.a/"$new_name"/st
-            cp -r "$dir"/unoicu.a ../nuget/uno.icu-wasm/buildTransitive/native/unoicu.a/"$new_name"/st/unoicu.a
+            SRC_BASE="$dir/unoicu.a"
+            if [ ! -d "$SRC_BASE" ]; then
+              SRC_BASE="$dir"
+            fi
+
+            find "$SRC_BASE" -mindepth 1 -maxdepth 1 -type d ! -name '*nosimd*' -print0 | while IFS= read -r -d '' version_dir; do
+              cp -R "$version_dir" ../nuget/uno.icu-wasm/buildTransitive/native/unoicu.a/
+            done
          done


The artifact handling logic is complex with conditional path handling and nosimd filtering in two places (line 289 and 293). Consider documenting why nosimd variants are being excluded from the package, or extracting this logic into a more explicit and maintainable structure.

Copilot · 2026-01-13T16:41:27Z

.github/workflows/main.yml

+          SIMD_SUFFIX=$([ "${{ matrix.simd }}" = 'true' ] && echo ',simd' || echo '')
+          TEMP_SIMD_TAG=$([ "${{ matrix.simd }}" = 'true' ] && echo 'simd' || echo 'nosimd')
+          TEMP_OUTPUT="out/${{ matrix.EMSCRIPTEN_VERSION }}/${FEATURE_DIR}-${TEMP_SIMD_TAG}"
+          mkdir -p "${TEMP_OUTPUT}"
+
+          docker build --build-arg EMSCRIPTEN_VERSION=${{ matrix.EMSCRIPTEN_VERSION }} --build-arg IS_MULTITHREADED=${{ matrix.multithreaded }} --build-arg IS_SIMD_SUPPORTED=${{ matrix.simd }} --output type=local,dest=${TEMP_OUTPUT} .
+
+          FINAL_DIR="out/unoicu.a/${{ matrix.EMSCRIPTEN_VERSION }}/${FEATURE_DIR}${SIMD_SUFFIX}"


The variable name 'SIMD_SUFFIX' is misleading as it contains a comma prefix ',simd' (line 27) rather than a true suffix. Consider renaming to 'SIMD_PATH_COMPONENT' or 'SIMD_VARIANT' to better reflect its use in path construction.

Suggested change

SIMD_SUFFIX=$([ "${{ matrix.simd }}" = 'true' ] && echo ',simd' || echo '')

TEMP_SIMD_TAG=$([ "${{ matrix.simd }}" = 'true' ] && echo 'simd' || echo 'nosimd')

TEMP_OUTPUT="out/${{ matrix.EMSCRIPTEN_VERSION }}/${FEATURE_DIR}-${TEMP_SIMD_TAG}"

mkdir -p "${TEMP_OUTPUT}"

docker build --build-arg EMSCRIPTEN_VERSION=${{ matrix.EMSCRIPTEN_VERSION }} --build-arg IS_MULTITHREADED=${{ matrix.multithreaded }} --build-arg IS_SIMD_SUPPORTED=${{ matrix.simd }} --output type=local,dest=${TEMP_OUTPUT} .

FINAL_DIR="out/unoicu.a/${{ matrix.EMSCRIPTEN_VERSION }}/${FEATURE_DIR}${SIMD_SUFFIX}"

SIMD_PATH_COMPONENT=$([ "${{ matrix.simd }}" = 'true' ] && echo ',simd' || echo '')

TEMP_SIMD_TAG=$([ "${{ matrix.simd }}" = 'true' ] && echo 'simd' || echo 'nosimd')

TEMP_OUTPUT="out/${{ matrix.EMSCRIPTEN_VERSION }}/${FEATURE_DIR}-${TEMP_SIMD_TAG}"

mkdir -p "${TEMP_OUTPUT}"

docker build --build-arg EMSCRIPTEN_VERSION=${{ matrix.EMSCRIPTEN_VERSION }} --build-arg IS_MULTITHREADED=${{ matrix.multithreaded }} --build-arg IS_SIMD_SUPPORTED=${{ matrix.simd }} --output type=local,dest=${TEMP_OUTPUT} .

FINAL_DIR="out/unoicu.a/${{ matrix.EMSCRIPTEN_VERSION }}/${FEATURE_DIR}${SIMD_PATH_COMPONENT}"

Copilot · 2026-01-13T16:41:28Z

.github/workflows/main.yml

+          SIMD_SUFFIX=$([ "${{ matrix.simd }}" = 'true' ] && echo ',simd' || echo '')
+          TEMP_SIMD_TAG=$([ "${{ matrix.simd }}" = 'true' ] && echo 'simd' || echo 'nosimd')
+          TEMP_OUTPUT="out/${{ matrix.EMSCRIPTEN_VERSION }}/${FEATURE_DIR}-${TEMP_SIMD_TAG}"
+          mkdir -p "${TEMP_OUTPUT}"
+
+          docker build --build-arg EMSCRIPTEN_VERSION=${{ matrix.EMSCRIPTEN_VERSION }} --build-arg IS_MULTITHREADED=${{ matrix.multithreaded }} --build-arg IS_SIMD_SUPPORTED=${{ matrix.simd }} --output type=local,dest=${TEMP_OUTPUT} .
+
+          FINAL_DIR="out/unoicu.a/${{ matrix.EMSCRIPTEN_VERSION }}/${FEATURE_DIR}${SIMD_SUFFIX}"


The variable name 'SIMD_SUFFIX' is misleading as it contains a comma prefix ',simd' (line 27) rather than a true suffix. Consider renaming to 'SIMD_PATH_COMPONENT' or 'SIMD_VARIANT' to better reflect its use in path construction.

Suggested change

SIMD_SUFFIX=$([ "${{ matrix.simd }}" = 'true' ] && echo ',simd' || echo '')

TEMP_SIMD_TAG=$([ "${{ matrix.simd }}" = 'true' ] && echo 'simd' || echo 'nosimd')

TEMP_OUTPUT="out/${{ matrix.EMSCRIPTEN_VERSION }}/${FEATURE_DIR}-${TEMP_SIMD_TAG}"

mkdir -p "${TEMP_OUTPUT}"

docker build --build-arg EMSCRIPTEN_VERSION=${{ matrix.EMSCRIPTEN_VERSION }} --build-arg IS_MULTITHREADED=${{ matrix.multithreaded }} --build-arg IS_SIMD_SUPPORTED=${{ matrix.simd }} --output type=local,dest=${TEMP_OUTPUT} .

FINAL_DIR="out/unoicu.a/${{ matrix.EMSCRIPTEN_VERSION }}/${FEATURE_DIR}${SIMD_SUFFIX}"

SIMD_PATH_COMPONENT=$([ "${{ matrix.simd }}" = 'true' ] && echo ',simd' || echo '')

TEMP_SIMD_TAG=$([ "${{ matrix.simd }}" = 'true' ] && echo 'simd' || echo 'nosimd')

TEMP_OUTPUT="out/${{ matrix.EMSCRIPTEN_VERSION }}/${FEATURE_DIR}-${TEMP_SIMD_TAG}"

mkdir -p "${TEMP_OUTPUT}"

docker build --build-arg EMSCRIPTEN_VERSION=${{ matrix.EMSCRIPTEN_VERSION }} --build-arg IS_MULTITHREADED=${{ matrix.multithreaded }} --build-arg IS_SIMD_SUPPORTED=${{ matrix.simd }} --output type=local,dest=${TEMP_OUTPUT} .

FINAL_DIR="out/unoicu.a/${{ matrix.EMSCRIPTEN_VERSION }}/${FEATURE_DIR}${SIMD_PATH_COMPONENT}"

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T15:15:15Z

.github/workflows/main.yml

+          docker run --rm -v "$PWD":/src -w /src/validation/app emscripten/emsdk:${{ matrix.EMSCRIPTEN_VERSION }} \
+            emcc main.c ./unoicu.a \
+              -I"/src/${ICU_SOURCE_SUBPATH}/common" \
+              -I"/src/${ICU_SOURCE_SUBPATH}/i18n" \
+              -sALLOW_MEMORY_GROWTH=1 \
+              -sEXIT_RUNTIME=1 \
+              -sASSERTIONS=1 \
+              -o unoicu_test.html


The validation wasm compilation step does not use the same compilation flags (pthread and msimd128) that were used to build the unoicu.a archive being tested. When the archive is built with IS_MULTITHREADED=true, it includes -pthread flag, and when IS_SIMD_SUPPORTED=true, it includes -msimd128 flag. The validation test should use matching flags when compiling against the archive to ensure proper linking and functionality. Add conditional flags based on the matrix parameters to the emcc command.

Copilot · 2026-01-14T15:15:16Z

src/unoicu/Dockerfile

+
+

There is an extra blank line here. Consider removing one of the blank lines to maintain consistent spacing throughout the file.

ramezgerges and others added 5 commits January 13, 2026 10:48

chore: simd and multithreading

2130a75

chore: Apply suggestions from code review

7b83b50

Co-authored-by: Copilot <[email protected]>

ci: Fix artifact names

8d9f52d

ci: Adjust artifacfts naming

73ffee6

ci: Adjust package generation

fee5a53

Copilot AI review requested due to automatic review settings January 13, 2026 16:38

Copilot started reviewing on behalf of jeromelaban January 13, 2026 16:38 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

feat: Enable runtime tests

6bce77c

jeromelaban force-pushed the dev/jela/wasm-tests branch from 8066c26 to 6bce77c Compare January 13, 2026 16:49

ci: Fix the build

3a52ebd

Copilot AI review requested due to automatic review settings January 14, 2026 15:10

Copilot started reviewing on behalf of jeromelaban January 14, 2026 15:10 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

ebariche self-requested a review January 16, 2026 08:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Add unit testing for wasm variant #14

ci: Add unit testing for wasm variant #14

Uh oh!

jeromelaban commented Jan 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 14, 2026

Uh oh!

Copilot AI Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ci: Add unit testing for wasm variant #14

Are you sure you want to change the base?

ci: Add unit testing for wasm variant #14

Uh oh!

Conversation

jeromelaban commented Jan 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants