fix(iOS): FileOpenPicker not returning video files #22428
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform/ios 🍎
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the FileOpenPicker on iOS was not returning video files when selected by the user. The issue occurred because the implementation only checked for image URLs in the picker results, causing video selections to return null.
Changes:
- Enhanced PHPickerFilter configuration to support both images and videos based on FileTypeFilter
- Updated FinishedPickingMedia method to check for video URLs before falling back to image URLs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
107
to
127
| PHPickerFilter? pickerFilter = null; | ||
| if (hasImages && hasVideos) | ||
| { | ||
| // Support both images and videos | ||
| pickerFilter = PHPickerFilter.GetAnyFilterMatchingSubfilters([ | ||
| PHPickerFilter.ImagesFilter, PHPickerFilter.VideosFilter | ||
| ]); | ||
| } | ||
| else if (hasImages) | ||
| { | ||
| pickerFilter = PHPickerFilter.ImagesFilter; | ||
| } | ||
| else if (hasVideos) | ||
| { | ||
| pickerFilter = PHPickerFilter.VideosFilter; | ||
| } | ||
|
|
||
| var imageConfiguration = new PHPickerConfiguration | ||
| { | ||
| Filter = PHPickerFilter.ImagesFilter, | ||
| SelectionLimit = limit | ||
| Filter = pickerFilter, SelectionLimit = limit | ||
| }; |
There was a problem hiding this comment.
When neither hasImages nor hasVideos is true (e.g., FileTypeFilter contains only document extensions like .pdf), pickerFilter will be null. According to Apple's documentation, a null filter in PHPickerConfiguration means no filtering is applied, allowing all media types. This could lead to unexpected behavior when SuggestedStartLocation is PicturesLibrary but FileTypeFilter specifies non-media file types. Consider falling through to the default case (document picker) when pickerFilter is null, or documenting this edge case behavior.
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22428/wasm-skia-net9/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22428/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22428/docs/index.html |
Contributor
|
The build 192403 found UI Test snapshots differences: Details
|
Contributor
|
The build 192403 found UI Test snapshots differences: Details
|
Contributor
|
|
Contributor
|
The build 192403 found UI Test snapshots differences: Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: closes https://github.com/unoplatform/ziidms-private/issues/106
Previously only checked for image URLs, causing video selections to return null.
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️