directly piggyback BBM on pickup@penn, as indicated from Alma, filtered for ETAS#121
Draft
directly piggyback BBM on pickup@penn, as indicated from Alma, filtered for ETAS#121
Conversation
Member
|
we don't show a BBM request option for Item-level things (should we?). whether or not to show PickUp@Penn for items is determined here. https://github.com/upenn-libraries/discovery-app/blob/align_bbm_with_pickup_at_penn/app/controllers/franklin_alma_controller.rb#L441-L443 |
mksndz
approved these changes
Nov 23, 2020
Member
mksndz
left a comment
There was a problem hiding this comment.
makes sense that we don't want to offer BBM for an item if P@P is blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some cases for which pickup@penn may not appear, in which BBM nonetheless is introduced. This derives from the same logic determining Pickup@Penn at the bibliographic level.
see record, e.g., 9963526843503681
Open question: how does this apply to records where Pickup@Penn does not apply at the bibliographic level, but for individual items?