Skip to content

directly piggyback BBM on pickup@penn, as indicated from Alma, filtered for ETAS#121

Draft
magibney wants to merge 1 commit intomasterfrom
align_bbm_with_pickup_at_penn
Draft

directly piggyback BBM on pickup@penn, as indicated from Alma, filtered for ETAS#121
magibney wants to merge 1 commit intomasterfrom
align_bbm_with_pickup_at_penn

Conversation

@magibney
Copy link
Contributor

There are some cases for which pickup@penn may not appear, in which BBM nonetheless is introduced. This derives from the same logic determining Pickup@Penn at the bibliographic level.
see record, e.g., 9963526843503681

Open question: how does this apply to records where Pickup@Penn does not apply at the bibliographic level, but for individual items?

@magibney magibney requested a review from mksndz November 20, 2020 18:59
@mksndz
Copy link
Member

mksndz commented Nov 23, 2020

we don't show a BBM request option for Item-level things (should we?).

whether or not to show PickUp@Penn for items is determined here. https://github.com/upenn-libraries/discovery-app/blob/align_bbm_with_pickup_at_penn/app/controllers/franklin_alma_controller.rb#L441-L443

Copy link
Member

@mksndz mksndz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense that we don't want to offer BBM for an item if P@P is blocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants