Skip to content

[FIX] back-link chip styling and inline link spacing on legal pages#437

Open
unisA02 wants to merge 11 commits into
stagingfrom
405-legal-pages-back-link-looks-like-plain-text-missing-spaces-before-inline-links
Open

[FIX] back-link chip styling and inline link spacing on legal pages#437
unisA02 wants to merge 11 commits into
stagingfrom
405-legal-pages-back-link-looks-like-plain-text-missing-spaces-before-inline-links

Conversation

@unisA02

@unisA02 unisA02 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Who are you?

  • Campus / data / QA only: no code in this PR? Comment on the issue and skip the rest.
  • Developer: code PR to staging (CONTRIBUTING.md).
  • Maintainer / agent: full QA below plus issue hygiene for linked specs.

Summary

Fixed the back-link on legal pages so it renders as a styled chip/button instead of plain text, and fixed missing whitespace around inline links in the Contact sections (and lede paragraphs) of terms.astro and privacy.astro by flattening multi-line anchor markup onto single lines.

Linked issues: Closes #405

Developer checklist

  • bun test src
  • bun run lint (or Prettier on touched files)
  • Linked issue commented with this PR URL

QA Summary (code changes)

Automated:

  • Prettier passed: bunx prettier --check . (PR CI)
  • Unit tests passed: bun test src (PR CI)
  • Full lint passed (local): bun run lint
  • Build passed (local): bun run build (needs DATABASE_URL; not run in PR CI)

If auth, routing, or schema changed:

  • Admin redirects verified: /admin, /admin/login
  • Migration applied on Supabase (if drizzle/ changed)

If map chrome, editor, or side panel changed:

Known gaps:

  • No unit tests added — this is a styling/markup-only fix on static legal pages, not covered by existing test suite.

Follow-up:

  • None anticipated; flag if other pages use the same multi-line inline-link pattern and show the same spacing bug.

Issues updated (maintainers / detailed specs)

  • Linked issue(s) commented with this PR
  • Acceptance criteria / paths updated on issue body (issue-hygiene.md)
  • Last verified against staging: date set on linked issues

Test plan

  1. Run npm run dev (or bun run dev)
  2. Visit /terms and /privacy
  3. Confirm the "Back to Room TBA" link renders as a pill/chip with visible background and border, not plain text
  4. Confirm body copy reads with normal spacing — no "onDiscord"/"orMessenger" run-together text in the Contact sections
  5. Confirm the lede paragraph ("...provided by UPLB Tools volunteers.") has correct spacing around the link

smmariquit and others added 10 commits July 1, 2026 03:34
Release: side panel UX, auth hardening, map hover fixes
Hotfix: dorm detail panel crash
Hotfix: dorm detail panel crash (prod)
docs(agents): agentic browser verification guidance
fix(map-chrome): anchor shortcuts help in map column (#429)
fix(ui): review contrast, map hover labels, landing pitch (#425 #423 #421)
docs(agents): issue triage labels and parent/sub-issue guidance
fix(side-panel): mobile collapsed peek pill border radius
chore: Change typescript configuration
@vercel

vercel Bot commented Jul 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
saan-ang-room Ready Ready Preview, Comment Jul 1, 2026 9:40am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants