add boot transparency support #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
reviewed
Dec 10, 2025
abarisani
requested changes
Dec 26, 2025
|
|
||
| // loadFromUefiRoot reads the transparency configuration files from | ||
| // the UEFI partition. The entry argument allows per-bundle configurations. | ||
| func (c *Config) loadFromUefiRoot(entryPath string) (err error) { |
Contributor
There was a problem hiding this comment.
Per earlier comments, why UEFI specific?
Contributor
|
To address #9 the patch should always honor forward slashes when constructing paths for fs.FS and os.PathSeparator for any eventual pkg honoring os (e.g. filepath). |
abarisani
reviewed
Jan 13, 2026
|
|
||
| // Boot transparency configuration root directory and filenames. | ||
| const ( | ||
| transparencyRoot = `/transparency` |
Contributor
There was a problem hiding this comment.
As this is used only once in the code, it feels up to the caller rather than being hard coded here (hashPrefix or similar?). Also, what is the purpose of the leading /?
As this package has expectations on the file names to load these constants should probably be exported for documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable interaction with the transparency ecosystem for boot loading operation using the boot-transparency Go library functions.