chore: switch default from v5 to v6 #577
Open
+119
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ui-use-ink ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AlexD10S
commented
Jul 22, 2025
| @@ -6,13 +6,13 @@ runs: | |||
| - name: Download node artifact | |||
| uses: actions/download-artifact@v4 | |||
| with: | |||
| name: substrate-contracts-node | |||
| name: ink-node | |||
There was a problem hiding this comment.
The CI needs to run the ink-node for testing ink! v6 contracts
AlexD10S
commented
Jul 22, 2025
| @@ -53,31 +53,67 @@ describe('ERC20 Contract ', () => { | |||
|
|
|||
| it(`transfers ${transferValue} Units to another account`, () => { | |||
| selectMessage('transfer', 3); | |||
| cy.get('.form-field.to').find('.dropdown').click().find('.dropdown__option').eq(3).click(); | |||
| cy.get('.form-field.value').find('input[type="number"]').eq(0).type(`${transferValue}`); | |||
| cy.get('.form-field.to') | |||
There was a problem hiding this comment.
In all unit tests the main update was the way to select an address, before it was a dropdown to pick Alice/Bob, now we need to type the H160 address
AlexD10S
commented
Jul 22, 2025
| @@ -4,7 +4,14 @@ | |||
| import { beforeAllContracts, deploy } from '../support/util'; | |||
|
|
|||
| describe('Update contract metadata', () => { | |||
| const messages1 = ['new', 'newDefault', 'failedNew', 'echoAuction', 'revertOrTrap', 'debugLog']; | |||
| const messages1 = [ | |||
There was a problem hiding this comment.
Updated in the contract mother https://github.com/use-ink/ink/blob/master/integration-tests/internal/mother/lib.rs
AlexD10S
commented
Jul 22, 2025
| const timeout = 25000; | ||
|
|
||
| export function beforeAllContracts() { | ||
| export async function beforeAllContracts() { |
There was a problem hiding this comment.
We need to map the accounts Alice and Bob
AlexD10S
commented
Jul 22, 2025
| }, | ||
| 'DryRun getOptionNone': { | ||
| 1: '<code>null</code>', | ||
| }, | ||
| 'DryRun getResultError': { | ||
| 1: "<code>{\n ErrorWithMessage: 'This is the Error Message.',\n }</code>", | ||
| 1: '<code>EmptyError</code>', |
There was a problem hiding this comment.
AlexD10S
commented
Jul 22, 2025
| @@ -17,13 +14,13 @@ module.exports = { | |||
| 1: "<code>{\n accountIdValue: '5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM',\n balanceValueMax: '340,282,366,920,938,463,463,374,607,431,768,211,455',\n balanceValueMin: '0',\n hashValue:\n '0x0000000000000000000000000000000000000000000000000000000000000000',\n }</code>", | |||
| }, | |||
| 'DryRun getPrimitiveTypes': { | |||
| 1: "<code>{\n boolValue: true,\n enumWithoutValues: 'A',\n enumWithValues: {\n ThreeValues: [\n '1',\n '2',\n '3',\n ],\n },\n arrayValue: [\n '3',\n '2',\n '1',\n ],\n tupleValue: [\n '7',\n '8',\n ],\n }</code>", | |||
| 1: "<code>{\n boolValue: true,\n enumWithoutValues: 'A',\n enumWithValues: {\n ThreeValues: [\n '1',\n '2',\n '3',\n ],\n },\n arrayValue: [\n '3',\n '2',\n '1',\n ],\n tupleValue: [\n '7',\n '8',\n ],\n tupleTripletValue: [\n '-123',\n '0',\n '123',\n ],\n }</code>", | |||
There was a problem hiding this comment.
This was referenced Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we did in
cargo-contractsand theink-docsuse-ink/ink-docs#432 it makes sense to have ink! v6 as the default in Contracts UI as well.This PR includes a large number of file changes because the test contracts had to be updated to ink! v6, and the tests were adjusted accordingly.