Ush 1445 - Phone Input Field (Mobile)#1192
Open
ushahidlee wants to merge 10 commits intomobile-developmentfrom
Open
Ush 1445 - Phone Input Field (Mobile)#1192ushahidlee wants to merge 10 commits intomobile-developmentfrom
ushahidlee wants to merge 10 commits intomobile-developmentfrom
Conversation
Angamanga
approved these changes
Aug 15, 2024
Contributor
Angamanga
left a comment
Angamanga
left a comment
There was a problem hiding this comment.
Works fine as far as I could test it 👍
| <ng-container | ||
| *ngIf="field.input === 'text' && (field.type === 'title' || field.type === 'varchar')" | ||
| *ngIf="field.input === 'text' && (field.type === 'title' || field.type === 'varchar') && field.label !== 'mobile_test'" | ||
| > |
Contributor
There was a problem hiding this comment.
Is this for the temporary test-thing?
Contributor
Author
There was a problem hiding this comment.
yeah exactly. The new field will be a 'text' field in the backend, so its a very close simulation of end to end.
tuxpiper
force-pushed
the
mobile-development
branch
from
7cb22cf to
20da475
Compare
tuxpiper
force-pushed
the
mobile-development
branch
from
076c7d3 to
a07f1c1
Compare
Member
|
I’ve pulled it up to be based on the latest of mobile-development . The only conflicts were with packages.json and -lock.json . Those files I overwrote with the latest of mobile-development, so they would need to be reviewed again here if changes need to be re-introduced. |
Member
|
Changes on package.json after the rebase: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Our users would like a nice field specific to the entry of phone numbers.
Solution:
This PR wraps a widely used Javascript phone input library, with a Typescript Angular component so as to work inside of our ionic mobile app.
IMPORTANT: This PR has been implemented BEFORE the associated backend ticket and cannot be tested on the system at large until the backend ticket has been committed. The testing plan below can be employed until that time.
Testing:
(The last field in the survey is the mobile input field.)