docs: add docs for users, metrics etc.#1074
Closed
jtsextonMITRE wants to merge 21 commits intodevfrom
Closed
Conversation
keithmanville
requested changes
Dec 23, 2025
docs/source/how-to/essential-workflows/creating-param-types.rst
Outdated
Show resolved
Hide resolved
docs/source/how-to/essential-workflows/creating-param-types.rst
Outdated
Show resolved
Hide resolved
docs/source/explanation/components/users-groups-explanation.rst
Outdated
Show resolved
Hide resolved
docs/source/explanation/components/users-groups-explanation.rst
Outdated
Show resolved
Hide resolved
docs/source/explanation/components/users-groups-explanation.rst
Outdated
Show resolved
Hide resolved
colton-lapp
requested changes
Dec 29, 2025
Collaborator
There was a problem hiding this comment.
Overall it's looking good and it's exciting to see the docs come together! Left a couple comments where I would have benefitted from seeing more explanation, I was confused, or things could be styled/worded differently. Feel free to reject or ignore any suggestions
docs/source/how-to/essential-workflows/creating-users-groups.rst
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Jan 8, 2026
Closed
Closed
Closed
Closed
Closed
keithmanville
force-pushed
the
jtsexton-972-docs-rewrite
branch
from
2515f3a to
38ace0d
Compare
keithmanville
requested changes
Jan 22, 2026
|
|
||
| Use the client to update the entrypoint with the id of the queue. | ||
|
|
||
| .. automethod:: dioptra.client.entrypoints.EntrypointsCollectionClient.modify_by_id |
Collaborator
There was a problem hiding this comment.
I think we should recommend the queues sub endpoint instead.
dioptra/src/dioptra/client/entrypoints.py
Line 343 in 6e8fded
| @@ -18,7 +18,271 @@ | |||
| .. _explanation-plugin-parameter-types: | |||
Collaborator
There was a problem hiding this comment.
does this get too much into "reference" material?
jtsextonMITRE <45762017+jtsextonMITRE@users.noreply.github.com>
Co-authored-by: Keith Manville <kmanville@mitre.org>
The repository pattern implementation for sorting resources broke sorting by last_modified_on. The implementation used a mapping from field name to attribute name a corresponding sortable column, which was then used with `getattr` to get the sortable column object. This doesn't work when the attribute name isn't a attribute of the Resource type as is the case with `last_modified_on`. This commit changes the implementation to map the field name to the sortable column object directly. This matches the implementation currently in place for Resources that aren't using the repository pattern.
Collaborator
|
superseded by #1130 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1037, #1058, #1038, #1043, #1053, #1041