Fix: Rounded corners being clipped as rectangles in CompactLibraryTabBar#1293
Fix: Rounded corners being clipped as rectangles in CompactLibraryTabBar#1293sdkahal wants to merge 1 commit intoutkarshdalal:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA modifier order change in LibraryTabBar's compact tab strip: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Fixed a UI issue where the CompactLibraryTabBar (narrow/portrait mode) displayed rectangular sharp edges instead of rounded corners during horizontal scrolling.
The root cause was the incorrect order of Modifiers in the tab container. By applying .horizontalScroll() before .clip(), the scrolling viewport overrode the rounded shape, causing a "cut-off" look at the edges. I have reordered the Modifiers to apply .clip() and .background() before .horizontalScroll(), ensuring the capsule shape remains intact regardless of the scroll position.
Recording
before


now
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Fixes rounded corners being clipped as rectangles in the CompactLibraryTabBar during horizontal scrolling in compact/portrait mode. Reorders modifiers to apply clip and background before horizontalScroll, preserving the capsule shape while scrolling.
Written for commit 3c71df0. Summary will update on new commits.
Summary by CodeRabbit