Fix terminal detection permission issue (#179) #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Read tty_nr from /proc/PID/stat (field 7) which is world-readable - Add TryFrom<u64> implementation to decode tty_nr device numbers - Fix Display impl bug that had wrong device name mappings - Update tty() method to use stat file first, fall back to fd scanning - Update all callers to use mutable borrow for tty() method This fixes issue uutils#179 where pgrep -t would fail when run as a normal user because /proc/PID/fd is only readable by the process owner.
|
again, please stop with the AI generated comment 0 |
|
I don't know if you have seen it: |
The previous test relied on tty1 existing in the CI environment and used --inverse as a workaround. With the new terminal detection implementation that reads from /proc/<PID>/stat, the test behavior changed. This commit updates the test to: - Test with '?' (unknown terminal) which matches processes without terminals - Use kthreadd as a reliable test case (always has no terminal) - Test --inverse functionality more robustly This addresses the CI failure where test_terminal was panicking.
cakebaker
reviewed
Oct 11, 2025
Comment on lines
+119
to
+126
| 4 => { | ||
| if minor == 0 { | ||
| // /dev/tty0 is the current virtual console | ||
| Ok(Self::Tty(0)) | ||
| } else { | ||
| Ok(Self::Tty(minor)) | ||
| } | ||
| } |
There was a problem hiding this comment.
The condition is not really necessary:
Suggested change
| 4 => { | |
| if minor == 0 { | |
| // /dev/tty0 is the current virtual console | |
| Ok(Self::Tty(0)) | |
| } else { | |
| Ok(Self::Tty(minor)) | |
| } | |
| } | |
| 4 => Ok(Self::Tty(minor)), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #179 where pgrep -t would fail when run as a normal user because /proc/PID/fd is only readable by the process owner.