Skip to content

removals: DAAL_C11_OVERRIDE #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alexandr-Solovev wants to merge 4 commits into
base: main
Choose a base branch
from
Open

removals: DAAL_C11_OVERRIDE #3504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81a063d
fixes
Alexandr-Solovev Feb 4, 2026
6c46383
fixes
Alexandr-Solovev Feb 4, 2026
4bb1ec6
Merge branch 'main' into dev/asolovev_daal_override_removals
Alexandr-Solovev Feb 4, 2026
35c3719
Merge branch 'main' into dev/asolovev_daal_override_removals
Alexandr-Solovev Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/instructions/cpp-coding-guidelines.instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ template <typename algorithmFPType, Method method, CpuType cpu>
class BatchContainer : public daal::algorithms::AnalysisContainerIface<batch>
{
public:
virtual services::Status compute() DAAL_C11_OVERRIDE;
virtual services::Status compute() override;
};

template <typename DataType = DAAL_DATA_TYPE>
Expand Down
2 changes: 1 addition & 1 deletion cpp/AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ oneDAL provides **two distinct C++ interfaces**:
// DAAL - Multi-dimensional specialization for CPU optimization
template <typename algorithmFPType, Method method, CpuType cpu>
class BatchContainer : public daal::algorithms::AnalysisContainerIface<batch> {
virtual services::Status compute() DAAL_C11_OVERRIDE;
virtual services::Status compute() override;
};

// oneAPI - Type-safe dispatching with perfect forwarding
Expand Down
2 changes: 1 addition & 1 deletion cpp/daal/AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ services::Status compute() {
template <typename algorithmFPType, Method method, CpuType cpu>
class BatchContainer : public daal::algorithms::AnalysisContainerIface<batch> {
public:
virtual services::Status compute() DAAL_C11_OVERRIDE;
virtual services::Status compute() override;
};

// CPU type enumeration
Expand Down
2 changes: 1 addition & 1 deletion cpp/daal/include/algorithms/algorithm_base_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class AlgorithmIfaceImpl : public AlgorithmIface
* \return Error collection of the algorithm
* \DAAL_DEPRECATED
*/
services::SharedPtr<services::ErrorCollection> getErrors() DAAL_C11_OVERRIDE { return _status.getCollection(); }
services::SharedPtr<services::ErrorCollection> getErrors() override { return _status.getCollection(); }

private:
bool _enableChecks;
Expand Down
12 changes: 6 additions & 6 deletions cpp/daal/include/algorithms/algorithm_base_mode_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
/**
* Validates parameters of the compute method
*/
virtual services::Status checkComputeParams() DAAL_C11_OVERRIDE
virtual services::Status checkComputeParams() override

Check notice on line 123 in cpp/daal/include/algorithms/algorithm_base_mode_impl.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_base_mode_impl.h#L123 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)
{
services::Status s;
if (this->_par) s = this->_par->check();
Expand All @@ -130,23 +130,23 @@
/**
* Validates result parameters of the compute method
*/
virtual services::Status checkResult() DAAL_C11_OVERRIDE
virtual services::Status checkResult() override

Check notice on line 133 in cpp/daal/include/algorithms/algorithm_base_mode_impl.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_base_mode_impl.h#L133 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)
{
return this->_pres ? this->_pres->check(this->_in, this->_par, this->getMethod()) : services::Status(services::ErrorNullPartialResult);
}

/**
* Validates result parameters of the finalizeCompute method
*/
virtual services::Status checkPartialResult() DAAL_C11_OVERRIDE
virtual services::Status checkPartialResult() override

Check notice on line 141 in cpp/daal/include/algorithms/algorithm_base_mode_impl.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_base_mode_impl.h#L141 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)
{
return this->_pres ? this->_pres->check(this->_par, this->getMethod()) : services::Status(services::ErrorNullPartialResult);
}

/**
* Validates parameters of the finalizeCompute method
*/
virtual services::Status checkFinalizeComputeParams() DAAL_C11_OVERRIDE
virtual services::Status checkFinalizeComputeParams() override

Check notice on line 149 in cpp/daal/include/algorithms/algorithm_base_mode_impl.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_base_mode_impl.h#L149 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)
{
return this->_res ? this->_res->check(this->_pres, this->_par, this->getMethod()) : services::Status();
}
Expand Down Expand Up @@ -251,7 +251,7 @@
/**
* Validates parameters of the compute method
*/
virtual services::Status checkComputeParams() DAAL_C11_OVERRIDE
virtual services::Status checkComputeParams() override

Check notice on line 254 in cpp/daal/include/algorithms/algorithm_base_mode_impl.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_base_mode_impl.h#L254 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)
{
services::Status s;
if (_par)
Expand All @@ -266,7 +266,7 @@
/**
* Validates result parameters of the compute method
*/
virtual services::Status checkResult() DAAL_C11_OVERRIDE
virtual services::Status checkResult() override

Check notice on line 269 in cpp/daal/include/algorithms/algorithm_base_mode_impl.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_base_mode_impl.h#L269 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)
{
if (_res) return _res->check(_in, _par, getMethod());
return services::Status(services::ErrorNullResult);
Expand Down
10 changes: 5 additions & 5 deletions cpp/daal/include/algorithms/algorithm_container_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
*/
AlgorithmContainerIfaceImpl(daal::services::Environment::env * daalEnv) : _env(daalEnv), _kernel(NULL) {}

virtual ~AlgorithmContainerIfaceImpl() DAAL_C11_OVERRIDE {}
virtual ~AlgorithmContainerIfaceImpl() override {}

Check notice on line 78 in cpp/daal/include/algorithms/algorithm_container_base.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base.h#L78 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

/**
* Sets the information about the environment
Expand Down Expand Up @@ -206,13 +206,13 @@
*/
Result * getResult() const { return _res; }

virtual services::Status setupCompute() DAAL_C11_OVERRIDE { return services::Status(); }
virtual services::Status setupCompute() override { return services::Status(); }

Check notice on line 209 in cpp/daal/include/algorithms/algorithm_container_base.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base.h#L209 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

virtual services::Status resetCompute() DAAL_C11_OVERRIDE { return services::Status(); }
virtual services::Status resetCompute() override { return services::Status(); }

Check notice on line 211 in cpp/daal/include/algorithms/algorithm_container_base.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base.h#L211 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

virtual services::Status setupFinalizeCompute() DAAL_C11_OVERRIDE { return services::Status(); }
virtual services::Status setupFinalizeCompute() override { return services::Status(); }

Check notice on line 213 in cpp/daal/include/algorithms/algorithm_container_base.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base.h#L213 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

virtual services::Status resetFinalizeCompute() DAAL_C11_OVERRIDE { return services::Status(); }
virtual services::Status resetFinalizeCompute() override { return services::Status(); }

Check notice on line 215 in cpp/daal/include/algorithms/algorithm_container_base.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base.h#L215 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

protected:
Input * _in;
Expand Down
12 changes: 6 additions & 6 deletions cpp/daal/include/algorithms/algorithm_container_base_batch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
*/
AlgorithmContainer(daal::services::Environment::env * daalEnv) : AlgorithmContainerIfaceImpl(daalEnv) {}

virtual ~AlgorithmContainer() DAAL_C11_OVERRIDE {}
virtual ~AlgorithmContainer() override {}

Check notice on line 66 in cpp/daal/include/algorithms/algorithm_container_base_batch.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base_batch.h#L66 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

/**
* Computes final results of the algorithm.
Expand Down Expand Up @@ -127,9 +127,9 @@
*/
Result * getResult() { return _res; }

virtual services::Status setupCompute() DAAL_C11_OVERRIDE { return services::Status(); }
virtual services::Status setupCompute() override { return services::Status(); }

Check notice on line 130 in cpp/daal/include/algorithms/algorithm_container_base_batch.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base_batch.h#L130 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

virtual services::Status resetCompute() DAAL_C11_OVERRIDE { return services::Status(); }
virtual services::Status resetCompute() override { return services::Status(); }

Check notice on line 132 in cpp/daal/include/algorithms/algorithm_container_base_batch.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base_batch.h#L132 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

protected:
const Hyperparameter * _hpar;
Expand Down Expand Up @@ -177,19 +177,19 @@
_cntr = 0;
}

virtual services::Status compute() DAAL_C11_OVERRIDE
virtual services::Status compute() override

Check notice on line 180 in cpp/daal/include/algorithms/algorithm_container_base_batch.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base_batch.h#L180 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)
{
_cntr->setArguments(this->_in, this->_res, this->_par, this->_hpar);
return _cntr->compute();
}

virtual services::Status setupCompute() DAAL_C11_OVERRIDE
virtual services::Status setupCompute() override

Check notice on line 186 in cpp/daal/include/algorithms/algorithm_container_base_batch.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base_batch.h#L186 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)
{
_cntr->setArguments(this->_in, this->_res, this->_par, this->_hpar);
return _cntr->setupCompute();
}

virtual services::Status resetCompute() DAAL_C11_OVERRIDE { return _cntr->resetCompute(); }
virtual services::Status resetCompute() override { return _cntr->resetCompute(); }

Check notice on line 192 in cpp/daal/include/algorithms/algorithm_container_base_batch.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base_batch.h#L192 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

protected:
AlgorithmContainerImpl<batch> * _cntr;
Expand Down
8 changes: 4 additions & 4 deletions cpp/daal/include/algorithms/algorithm_container_base_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,27 +74,27 @@

virtual ~AlgorithmDispatchContainer() { delete _cntr; }

virtual services::Status compute() DAAL_C11_OVERRIDE
virtual services::Status compute() override

Check notice on line 77 in cpp/daal/include/algorithms/algorithm_container_base_common.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base_common.h#L77 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)
{
_cntr->setArguments(this->_in, this->_pres, this->_par, this->_hpar);
return _cntr->compute();
}

virtual services::Status finalizeCompute() DAAL_C11_OVERRIDE
virtual services::Status finalizeCompute() override

Check notice on line 83 in cpp/daal/include/algorithms/algorithm_container_base_common.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base_common.h#L83 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)
{
_cntr->setArguments(this->_in, this->_pres, this->_par, this->_hpar);
_cntr->setResult(this->_res);
return _cntr->finalizeCompute();
}

virtual services::Status setupCompute() DAAL_C11_OVERRIDE
virtual services::Status setupCompute() override

Check notice on line 90 in cpp/daal/include/algorithms/algorithm_container_base_common.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base_common.h#L90 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)
{
_cntr->setArguments(this->_in, this->_pres, this->_par, this->_hpar);
_cntr->setResult(this->_res);
return _cntr->setupCompute();
}

virtual services::Status resetCompute() DAAL_C11_OVERRIDE { return _cntr->resetCompute(); }
virtual services::Status resetCompute() override { return _cntr->resetCompute(); }

Check notice on line 97 in cpp/daal/include/algorithms/algorithm_container_base_common.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/algorithm_container_base_common.h#L97 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

protected:
AlgorithmContainerImpl<mode> * _cntr;
Expand Down
4 changes: 2 additions & 2 deletions cpp/daal/include/algorithms/algorithm_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,14 +508,14 @@ class DAAL_EXPORT OptionalArgument : public SerializableArgument
return services::Status();
}

services::Status serializeImpl(data_management::InputDataArchive * arch) DAAL_C11_OVERRIDE
services::Status serializeImpl(data_management::InputDataArchive * arch) override
{
serialImpl<data_management::InputDataArchive, false>(arch);

return services::Status();
}

services::Status deserializeImpl(const data_management::OutputDataArchive * arch) DAAL_C11_OVERRIDE
services::Status deserializeImpl(const data_management::OutputDataArchive * arch) override
{
serialImpl<const data_management::OutputDataArchive, true>(arch);

Expand Down
2 changes: 1 addition & 1 deletion cpp/daal/include/algorithms/analysis.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class AnalysisContainerIface : public AlgorithmContainerImpl<mode>

AnalysisContainerIface(const AnalysisContainerIface &) = delete;
AnalysisContainerIface<mode> & operator=(const AnalysisContainerIface<mode> & other) = delete;
~AnalysisContainerIface() DAAL_C11_OVERRIDE = default;
~AnalysisContainerIface() override = default;
};

/**
Expand Down
6 changes: 3 additions & 3 deletions cpp/daal/include/algorithms/association_rules/apriori.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
* Returns method of the algorithm
* \return Method of the algorithm
*/
virtual int getMethod() const DAAL_C11_OVERRIDE { return (int)method; }
virtual int getMethod() const override { return (int)method; }

Check notice on line 111 in cpp/daal/include/algorithms/association_rules/apriori.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/association_rules/apriori.h#L111 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

/**
* Returns the structure that contains results of the association rules algorithm
Expand Down Expand Up @@ -136,9 +136,9 @@
services::SharedPtr<Batch<algorithmFPType, method> > clone() const { return services::SharedPtr<Batch<algorithmFPType, method> >(cloneImpl()); }

protected:
virtual Batch<algorithmFPType, method> * cloneImpl() const DAAL_C11_OVERRIDE { return new Batch<algorithmFPType, method>(*this); }
virtual Batch<algorithmFPType, method> * cloneImpl() const override { return new Batch<algorithmFPType, method>(*this); }

Check notice on line 139 in cpp/daal/include/algorithms/association_rules/apriori.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/association_rules/apriori.h#L139 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

virtual services::Status allocateResult() DAAL_C11_OVERRIDE
virtual services::Status allocateResult() override

Check notice on line 141 in cpp/daal/include/algorithms/association_rules/apriori.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/association_rules/apriori.h#L141 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)
{
services::Status s = _result->allocate<algorithmFPType>(&input, &parameter, (int)method);
_res = _result.get();
Expand Down
6 changes: 3 additions & 3 deletions cpp/daal/include/algorithms/association_rules/apriori_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ struct DAAL_EXPORT Parameter : public daal::algorithms::Parameter
/**
* Checks parameters of the association rules algorithm
*/
services::Status check() const DAAL_C11_OVERRIDE;
services::Status check() const override;
};
/* [Parameter source code] */

Expand Down Expand Up @@ -166,7 +166,7 @@ class DAAL_EXPORT Input : public daal::algorithms::Input
* \param[in] par %Parameter of the algorithm
* \param[in] method Computation method of the algorithm
*/
services::Status check(const daal::algorithms::Parameter * par, int method) const DAAL_C11_OVERRIDE;
services::Status check(const daal::algorithms::Parameter * par, int method) const override;
};

/**
Expand Down Expand Up @@ -210,7 +210,7 @@ class DAAL_EXPORT Result : public daal::algorithms::Result
* \param[in] par %Parameter of algorithm
* \param[in] method Computation method of the algorithm
*/
services::Status check(const daal::algorithms::Input * input, const daal::algorithms::Parameter * par, int method) const DAAL_C11_OVERRIDE;
services::Status check(const daal::algorithms::Input * input, const daal::algorithms::Parameter * par, int method) const override;

protected:
using daal::algorithms::interface1::Result::check;
Expand Down
4 changes: 2 additions & 2 deletions cpp/daal/include/algorithms/boosting/adaboost_model.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ struct DAAL_EXPORT Parameter : public classifier::Parameter
size_t maxIterations; /*!< Maximal number of iterations of the AdaBoost training algorithm */
double learningRate; /*!< Multiplier for each classifier to shrink its contribution */
DAAL_UINT64 resultsToCompute; /*!< 64 bit integer flag that indicates the results to compute */
services::Status check() const DAAL_C11_OVERRIDE;
services::Status check() const override;
};
/* [Parameter source code] */

Expand Down Expand Up @@ -169,7 +169,7 @@ class DAAL_EXPORT Model : public classifier::Model
* Retrieves the number of features in the dataset was used on the training stage
* \return Number of features in the dataset was used on the training stage
*/
size_t getNumberOfFeatures() const DAAL_C11_OVERRIDE { return _nFeatures; }
size_t getNumberOfFeatures() const override { return _nFeatures; }

/**
* Returns a pointer to the array of weights of weak learners constructed
Expand Down
10 changes: 5 additions & 5 deletions cpp/daal/include/algorithms/boosting/adaboost_predict.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
/**
* Computes the result of AdaBoost model-based prediction
*/
services::Status compute() DAAL_C11_OVERRIDE;
services::Status compute() override;
};
/**
* <a name="DAAL-CLASS-ALGORITHMS__ADABOOST__PREDICTION__BATCH"></a>
Expand Down Expand Up @@ -155,13 +155,13 @@
* Get input objects for the AdaBoost prediction algorithm
* \return %Input objects for the AdaBoost prediction algorithm
*/
InputType * getInput() DAAL_C11_OVERRIDE { return &input; }
InputType * getInput() override { return &input; }

/**
* Returns method of the algorithm
* \return Method of the algorithm
*/
virtual int getMethod() const DAAL_C11_OVERRIDE { return (int)method; }
virtual int getMethod() const override { return (int)method; }

Check notice on line 164 in cpp/daal/include/algorithms/boosting/adaboost_predict.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/boosting/adaboost_predict.h#L164 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

/**
* Returns a pointer to the newly allocated AdaBoost prediction algorithm with a copy of input objects
Expand All @@ -171,9 +171,9 @@
services::SharedPtr<Batch<algorithmFPType, method> > clone() const { return services::SharedPtr<Batch<algorithmFPType, method> >(cloneImpl()); }

protected:
virtual Batch<algorithmFPType, method> * cloneImpl() const DAAL_C11_OVERRIDE { return new Batch<algorithmFPType, method>(*this); }
virtual Batch<algorithmFPType, method> * cloneImpl() const override { return new Batch<algorithmFPType, method>(*this); }

Check notice on line 174 in cpp/daal/include/algorithms/boosting/adaboost_predict.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/boosting/adaboost_predict.h#L174 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

services::Status allocateResult() DAAL_C11_OVERRIDE
services::Status allocateResult() override
{
services::Status s = _result->allocate<algorithmFPType>(&input, _par, 0);
_res = _result.get();
Expand Down
2 changes: 1 addition & 1 deletion cpp/daal/include/algorithms/boosting/adaboost_predict_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class DAAL_EXPORT Input : public classifier::prediction::Input
* \param[in] parameter Pointer to the structure of the algorithm parameters
* \param[in] method Computation method
*/
services::Status check(const daal::algorithms::Parameter * parameter, int method) const DAAL_C11_OVERRIDE;
services::Status check(const daal::algorithms::Parameter * parameter, int method) const override;
};

} // namespace interface2
Expand Down
12 changes: 6 additions & 6 deletions cpp/daal/include/algorithms/boosting/adaboost_training_batch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
/**
* Computes the result of AdaBoost model-based training in the batch processing mode
*/
services::Status compute() DAAL_C11_OVERRIDE;
services::Status compute() override;
};
/**
* <a name="DAAL-CLASS-ALGORITHMS__ADABOOST__TRAINING__BATCH"></a>
Expand Down Expand Up @@ -127,13 +127,13 @@
* Get input objects for the AdaBoost training algorithm
* \return %Input objects for the AdaBoost training algorithm
*/
InputType * getInput() DAAL_C11_OVERRIDE { return &input; }
InputType * getInput() override { return &input; }

/**
* Returns method of the algorithm
* \return Method of the algorithm
*/
virtual int getMethod() const DAAL_C11_OVERRIDE { return (int)method; }
virtual int getMethod() const override { return (int)method; }

Check notice on line 136 in cpp/daal/include/algorithms/boosting/adaboost_training_batch.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/boosting/adaboost_training_batch.h#L136 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

/**
* Returns the structure that contains results of AdaBoost training
Expand All @@ -144,7 +144,7 @@
/**
* Resets the training results of the classification algorithm
*/
services::Status resetResult() DAAL_C11_OVERRIDE
services::Status resetResult() override
{
_result.reset(new ResultType());
DAAL_CHECK(_result, services::ErrorNullResult);
Expand All @@ -160,9 +160,9 @@
services::SharedPtr<Batch<algorithmFPType, method> > clone() const { return services::SharedPtr<Batch<algorithmFPType, method> >(cloneImpl()); }

protected:
virtual Batch<algorithmFPType, method> * cloneImpl() const DAAL_C11_OVERRIDE { return new Batch<algorithmFPType, method>(*this); }
virtual Batch<algorithmFPType, method> * cloneImpl() const override { return new Batch<algorithmFPType, method>(*this); }

Check notice on line 163 in cpp/daal/include/algorithms/boosting/adaboost_training_batch.h

View check run for this annotation

codefactor.io / CodeFactor

cpp/daal/include/algorithms/boosting/adaboost_training_batch.h#L163 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

services::Status allocateResult() DAAL_C11_OVERRIDE
services::Status allocateResult() override
{
ResultPtr res = getResult();
DAAL_CHECK(res, services::ErrorNullResult);
Expand Down
2 changes: 1 addition & 1 deletion cpp/daal/include/algorithms/boosting/adaboost_training_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class DAAL_EXPORT Result : public classifier::training::Result
*/
void set(ResultNumericTableId id, const data_management::NumericTablePtr & value);

services::Status check(const daal::algorithms::Input * input, const daal::algorithms::Parameter * parameter, int method) const DAAL_C11_OVERRIDE;
services::Status check(const daal::algorithms::Input * input, const daal::algorithms::Parameter * parameter, int method) const override;

protected:
using daal::algorithms::interface1::Result::check;
Expand Down
Loading
Loading