Skip to content

removals: DAAL_C11_OVERRIDE#3504

Open
Alexandr-Solovev wants to merge 4 commits intouxlfoundation:mainfrom
Alexandr-Solovev:dev/asolovev_daal_override_removals
Open

removals: DAAL_C11_OVERRIDE#3504
Alexandr-Solovev wants to merge 4 commits intouxlfoundation:mainfrom
Alexandr-Solovev:dev/asolovev_daal_override_removals

Conversation

@Alexandr-Solovev
Copy link
Contributor

@Alexandr-Solovev Alexandr-Solovev commented Feb 4, 2026

Description

This PR removes the DAAL_C11_OVERRIDE macro and replaces its usages with the standard C++ override keyword.

The macro was previously used as a compatibility wrapper for older compilers.

Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@Alexandr-Solovev Alexandr-Solovev added the interfaces Update interfaces label Feb 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@david-cortes-intel
Copy link
Contributor

/intelci: run

@ethanglaser
Copy link
Contributor

Created a similar branch in sklearnex which appears to help with the linux CI but there are still issues on windows: http://intel-ci.intel.com/f102e86d-e63e-f1bb-bf2e-a4bf010d0e2d

@david-cortes-intel
Copy link
Contributor

Looks like something went wrong in the CI:

WARNING - Unable to find /localdisk2/mkl/mkltest/ec/oneDAL-CI-dev_asolovev_daal_override_removals-723603-20260205092108/build/onedal_linux_icx/__release_lnx/daal4py-3.10 for component lnx_sklearnex_3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interfaces Update interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants