Open
Conversation
01a743b to
3a0e59e
Compare
c6df869 to
3011cd7
Compare
3011cd7 to
20240af
Compare
syurkevi
approved these changes
Mar 13, 2026
TaoLv
reviewed
Mar 13, 2026
| BACKEND_DNNL_ADD_PASS(pipeline, fuse_mul_sigmoid_to_swish); | ||
| BACKEND_DNNL_ADD_PASS(pipeline, fuse_to_dnnl_sum); | ||
| BACKEND_DNNL_ADD_PASS(pipeline, fuse_to_shuffle); | ||
| BACKEND_DNNL_ADD_PASS(pipeline, decompose_softmax); |
Contributor
There was a problem hiding this comment.
Will this affect all patterns containing softmax?
Contributor
Author
There was a problem hiding this comment.
good point, I think so, I'll need to update patterns that contain softmax, currently there's only one of such patterns - single softmax pattern.
20240af to
5638f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: please review #4825 first.
Implementation of Proposal 2.C in RFC:
SDPA backwards w/ Dropout, gradients for masks are not enabled in this PR, will create separate PRs.
Rebase to latest implementation of fused sdpa training #4498
Currently there are still some correctness issue, but it doesn't seem to be computation error.