[backport][rls-v3.11] fix: common: memory_desc: add upper bounds check for md tensor dimensions#4852
Open
avmanerikar wants to merge 2 commits intorls-v3.11from
Open
[backport][rls-v3.11] fix: common: memory_desc: add upper bounds check for md tensor dimensions#4852avmanerikar wants to merge 2 commits intorls-v3.11from
avmanerikar wants to merge 2 commits intorls-v3.11from
Conversation
github-actions
bot
added
platform:cpu-x64
Contributor
Author
|
make test |
Sqvid
approved these changes
Mar 19, 2026
densamoilov
approved these changes
Mar 20, 2026
asimonov1
reviewed
Mar 21, 2026
| // computation does not trigger a overflow during memory creation. | ||
| dim_t prod = 1; | ||
| for (int d = 0; d < ndims; ++d) { | ||
| if (dims[d] != DNNL_RUNTIME_DIM_VAL) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (dims[d] != DNNL_RUNTIME_DIM_VAL) { | |
| if (!is_runtime_value(dims[d])) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of PR #4745.
Also backports commit a478090 from PR #4779 to use
is_runtime_value()in the fix.