Open
Conversation
Print a csv header in perf mode (alongside the existing perf template), which removes the % and expands DESC into the driver specific entries. This make the output much easier to process with other tools.
Contributor
|
I wonder if we actually need information included into problem descriptor ( This approach has a benefit of keeping the same number of columns between different primitives in CSV format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Most of the
benchdnnperf-templates already emit CSV-shaped data, but there are no headers, and the template doesn't match the columns. Specifically,%DESC%can expand to multiple columns for some drivers, which makes the output hard to parse. This change adds a CSV header row that matches each driver's concrete%DESC%expansion while preserving the existingOutput template: ...banner. This makes the CSV output easy to consume with standard tools (e.g.xsv).E.g. after this change,
./tests/benchdnn/benchdnn --conv --mode=P --perf-template=csv mb1_ic1oc1_id1ih5iw5_od1oh3ow3_kd1kh3kw3_sd1sh1sw1_pd0ph0pw0_dd0dh0dw0 \ | grep '^perf,' \ | xsv table perf engine impl name dir sdt stag wtag dtag alg attr g mb ic id ih iw oc od oh ow kd kh kw sd sh sw pd ph pw dd dh dw Gops max_ctime min_time min_Gflops avg_time avg_Gflops perf cpu jit:sve_128 FWD_B f32:f32:f32 any any any direct 1 1 1 1 5 5 1 1 3 3 1 3 3 1 1 1 0 0 0 0 0 0 1.62e-07 0.994385 0.137695 0.00117651 0.32537 0.000497895Not sure how to test this using ctest, I'm open to ideas...
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?