Actually use --dbupgrade-tag when computing the image URL #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaannz
approved these changes
Oct 10, 2025
There are a few points fixed in this commit around the dbupgrade
computation (bsc#1249400):
- the default tag should be "" to reuse the global tag
- appending the migration suffix to the server image name should not
be done in the ComputeImage as it makes it more complex.
- unit tests are badly needed
The added unit test could be extended to cover more than the image that
are computed and used, but this will wait.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
There are a few points fixed in this commit around the dbupgrade computation (bsc#1249400):
The added unit test could be extended to cover more than the image that are computed and used, but this will wait.
Test coverage
Unit tests were added
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/28367
Ports: https://github.com/SUSE/uyuni-tools/pull/137
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox: