Skip to content

Conversation

pablorodriguesb
Copy link

…adin#7689)

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes #7689

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@CLAassistant
Copy link

CLAassistant commented Jul 17, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pablorodriguesb
Copy link
Author

Hi! I have formatted the code locally (mvn spotless:apply) and all looks correct on my side.
It seems the failed checks are due to CI permissions for external contributors ("user is not a flow-components team member").
SThank you!

@vursen
Copy link
Contributor

vursen commented Jul 17, 2025

Thanks for your contribution. It seems like the root issue is that Grid allows rows to be dropped onto header rows, so addressing that might actually be a better solution. Receiving an incorrect DropEvent seems more like a symptom.

@trendelmann
Copy link

...so it is not yet public in any release?

@trendelmann
Copy link

trendelmann commented Oct 10, 2025

We as a customer / consumer of YOUR grid cannot address here anything - sorry. The Vaadin grid try to construct the DropEvent, that in turn fails. The DropEvent completes the drag-n-drop sequence, and we cannot do anything in between.
So we do NOT "Receiving an incorrect DropEvent...", we get nothing - because the creation of the DropEvent parameter failed completely and breaks the sequence mentioned.

So please fix that anyway and make it into a upcoming release, please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GridDropEvent throws Exception when dropping Row on Header

4 participants