Skip to content

Fix encoding issue, lower the limit for multipart requests #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix encoding issue, lower the limit for multipart requests #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions flask_mwoauth/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,15 +114,18 @@ def _prepare_long_request(url, api_query):
if k in ('title', 'text', 'summary'):
# title, text and summary values in the request
# should be utf-8 encoded
if isinstance(v, unicode):
v = v.encode('utf-8')

part = (k,
(None, v.encode('utf-8'),
(None, v,
'text/plain; charset=UTF-8',
{'Content-Transfer-Encoding': '8bit'}
)
)
else:
part = (k, (None, v))

partlist.append(part)

return Request(url=url, files=partlist).prepare()
Expand All @@ -136,11 +139,10 @@ def request(self, api_query, url=None):

size = sum([sys.getsizeof(v) for k, v in api_query.iteritems()])

if size > (1024 * 8):
# if request is bigger than 8 kB (the limit is somewhat arbitrary,
if size > (1024 * 4):
# if request is bigger than 4 kB (the limit is somewhat arbitrary,
# see https://www.mediawiki.org/wiki/API:Edit#Large_texts) then
# transmit as multipart message

req = self._prepare_long_request(url=url + "/api.php?",
api_query=api_query
)
Expand Down