Changes to use word-based bitwise processing for slot updates#3539
Open
omanges wants to merge 3 commits intovalkey-io:unstablefrom
Open
Changes to use word-based bitwise processing for slot updates#3539omanges wants to merge 3 commits intovalkey-io:unstablefrom
omanges wants to merge 3 commits intovalkey-io:unstablefrom
Conversation
omanges
force-pushed
the
optimise_slot_migration
branch
2 times, most recently
from
fa52212 to
2ca1d60
Compare
Signed-off-by: Omkar Mestry <om.m.mestry@gmail.com>
omanges
force-pushed
the
optimise_slot_migration
branch
from
2ca1d60 to
4639d4c
Compare
Member
|
@omanges Tests seem to be failing, so there is probably a functional bug. Can you take a look and try to fix it? |
Contributor
Author
Yeah will take a look and fix the test issues |
omanges
force-pushed
the
optimise_slot_migration
branch
3 times, most recently
from
b3cde13 to
9c4d878
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3539 +/- ##
============================================
- Coverage 76.66% 76.39% -0.28%
============================================
Files 159 159
Lines 80114 80131 +17
============================================
- Hits 61423 61217 -206
- Misses 18691 18914 +223
🚀 New features to boost your workflow:
|
omanges
force-pushed
the
optimise_slot_migration
branch
from
9c4d878 to
66eac8c
Compare
Contributor
Author
|
@madolson I have fixed the failing test, can you please have a look ? |
omanges
force-pushed
the
optimise_slot_migration
branch
from
66eac8c to
eba5972
Compare
omanges
force-pushed
the
optimise_slot_migration
branch
from
eba5972 to
36f79e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the current byte-by-byte slot update mechanism with word-based bitwise processing. This change improves the efficiency of cluster slot management by leveraging larger bitwise operations to reduce computational overhead during slot migrations and state synchronizations.