Skip to content

ci: Add slow tag to fuzzer and expand libc-malloc CI to run tests #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjuleslasarte wants to merge 4 commits into
base: unstable
Choose a base branch
from
+22 −16
Open

ci: Add slow tag to fuzzer and expand libc-malloc CI to run tests #3589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bcfa0e5
ci: Add slow tag to fuzzer and expand libc-malloc CI to run tests
jjuleslasarte Apr 29, 2026
e2e4a11
Merge branch 'unstable' into ci-improve-test-coverage-625
jjuleslasarte Apr 29, 2026
00db788
Update .github/workflows/ci.yml
jjuleslasarte May 1, 2026
9b40463
ci: Move test-ubuntu-libc-malloc before build-debian-old
lasartej May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,27 @@ jobs:
- name: test-tls-builtin
run: ./runtest --verbose --single unit/tls --dump-logs --tls

test-ubuntu-libc-malloc:
runs-on: ubuntu-latest
steps:
- name: Install libbacktrace
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
repository: ianlancetaylor/libbacktrace
ref: b9e40069c0b47a722286b94eb5231f7f05c08713
path: libbacktrace
- run: cd libbacktrace && ./configure && make && sudo make install
- name: Checkout Valkey
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: make
run: make -j4 SERVER_CFLAGS='-Werror' MALLOC=libc CFLAGS=-DNO_MALLOC_USABLE_SIZE USE_LIBBACKTRACE=yes
- name: test
run: |
sudo apt-get install -y tcl8.6 tclx
./runtest --verbose --tags -slow --dump-logs
- name: module api test
run: CFLAGS='-Werror' ./runtest-moduleapi --verbose --dump-logs

build-debian-old:
runs-on: ubuntu-latest
container: debian:bullseye
Expand Down Expand Up @@ -287,21 +308,6 @@ jobs:
GTEST_CFLAGS="-I/usr/src/googletest/googletest/include -I/usr/src/googletest/googlemock/include" \
GTEST_LIBS="/usr/lib32/libgtest.a /usr/lib32/libgmock.a"

build-libc-malloc:
runs-on: ubuntu-latest
steps:
- name: Install libbacktrace
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
repository: ianlancetaylor/libbacktrace
ref: b9e40069c0b47a722286b94eb5231f7f05c08713
path: libbacktrace
- run: cd libbacktrace && ./configure && make && sudo make install
- name: Checkout Valkey
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: make
run: make -j4 SERVER_CFLAGS='-Werror' MALLOC=libc USE_LIBBACKTRACE=yes

build-almalinux8-jemalloc:
runs-on: ubuntu-latest
container: almalinux:8
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/corrupt-dump-fuzzer.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# The fuzzer can cause corrupt the state in many places, which could
# mess up the reply, so we decided to skip logreqres.
tags {"dump" "corruption" "external:skip" "logreqres:skip"} {
tags {"dump" "corruption" "slow" "external:skip" "logreqres:skip"} {

# catch sigterm so that in case one of the random command hangs the test,
# usually due to the server not putting a response in the output buffers,
Expand Down
Loading