Skip to content

RxJS6 code migration #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 354 commits into
base: master
Choose a base branch
from
Open

RxJS6 code migration #971

wants to merge 354 commits into from

Conversation

prikryl
Copy link

@prikryl prikryl commented Oct 30, 2018

removed rxjs-compat dependency. Fixed imports to rxjs/operators. Migrated code to RxJS6 style.

@optimistex
upgrade to @angular/cli: 1.6.1
47daf38
@optimistex
"version": "2.1.1"
069ebd2
@optimistex
divide code and layout
b622d96
@optimistex
fix lint errors
af20e93
@optimistex
refactoring
0baf839
@optimistex
fix demo styles
8408c27
@optimistex
Merge branch 'v2.1' into v2.2
c81e895
@optimistex
bugfix
3235a4f
@optimistex
refactoring layout
12a1906
@optimistex
optimise the template of options
552b80c
@optimistex
refactoring
eefe736
@optimistex
make tests in the AAA (Arrange-Act-Assert) format
dc5d51e
@optimistex
fix auto scroll to active item for single select
6a42b80
@optimistex
release 2.1.3
9ab485d
@optimistex
update tests
ab7cd04
@optimistex
remove interface the OptionsBehavior
b69add0
@optimistex
add tests with bug fixes
7bf6ac2
@optimistex
bug fix: item with id === 0 was skipped
3dede43
@optimistex
add tests for SelectItem & make bug fixes
51a02a8
@optimistex
release 2.1.4
bcb4797
@optimistex
add tests "should set selected items ..."
5d0055f
@optimistex
bug fix: does not activated selected item in the choices after lazy l…
916c1b4 
…oad items

new: the items did become available to read
new: the items did become support with live changes
@optimistex
release 2.1.5
d4e6516
@optimistex
rebuild docs
c1ca504
@optimistex
little fix
a4545c0
@optimistex
implementing ngx-select
c2ee173
@optimistex
implementing ngx-select
20c3b54
@optimistex
implementing ngx-select: menu should be closed ...
999f914
@optimistex
implementing ngx-select: after open menu with no selected item first …
c1589d7 
…item is active
@optimistex
refactoring
55955ef
ert78gb and others added 26 commits July 1, 2018 22:49
@ert78gb
feat: add option to auto activate element on mouse enter
0b70a1b
@ert78gb
fix: highlight selected item
a660d86
@ert78gb
feat: use OnPush change detection
73e15bb
@oscarlocatelli
feature: pass search text to not found template
070034b
@oscarlocatelli
doc: add to doc new let-input variable
8c54409
@oscarlocatelli
fix: fixed inputElRef accessibility problem
f0043ca
Merge branch 'ert78gb-feat-no-scroll-on-edge' into development
741c560 
# Conflicts:
#	src/app/lib/ngx-select/ngx-select.component.ts
fix doc
15c81e6
fix doc
547e307
Merge branch 'oscarlocatelli-master'
0c24833
upgrade to Angular: 6.1.9 (Angular CLI: 6.2.3)
b343bde
release 3.6.0-dev
d8d7c37
@ert78gb
fix: highlighted text calculation
ad2f9a1
@ert78gb
fix: improve the speed of the subjOptionsSelected calculation
dd574d7
@ert78gb
fix: improve performance
512b87f
@ert78gb
style: format code
9568980
@ert78gb
fix: keyAction order
35b920a
issue: update rxjs to 6.3.3 ngx-select issue optimistex#118
35b01f0
release 3.6.1
ff4deeb
Merge branch 'development' into merging
169b999 
# Conflicts:
#	src/app/lib/ngx-select/ngx-select.component.ts
release 3.6.2-dev with the performance improves by "Róbert Kiss ert78…
7c49284 
…gb" optimistex#119
build docs
8467cc2
Merge branch 'master' into development
4af2529
fix: Multi selections are always sorted in alphabetical order. optimi…
be6badf 
…stex#121
release 3.6.3
9cc12d5
@prikryl
[72] removed rxjs-compat dependency. Fixed imports to rxjs/operators.…
d15d6ce 
… Migrated code to RxJS6 style.
@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@8aee01c). Click here to learn what that means.
The diff coverage is 81.41%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #971   +/-   ##
========================================
  Coverage          ?   82.6%           
========================================
  Files             ?      13           
  Lines             ?     575           
  Branches          ?     137           
========================================
  Hits              ?     475           
  Misses            ?      21           
  Partials          ?      79
Impacted Files Coverage Δ
src/test.ts 100% <100%> (ø)
src/app/demo/sample-section.component.ts 45.45% <14.28%> (ø)
src/app/lib/ngx-select/ngx-templates.directive.ts 68.42% <45.45%> (ø)
src/app/lib/ngx-select/ngx-select.module.ts 54.54% <50%> (ø)
src/app/demo/select/children-demo.ts 63.63% <55.55%> (ø)
src/app/demo/select/rich-demo.ts 58.82% <56.25%> (ø)
src/app/app.component.ts 62.5% <60%> (ø)
src/app/demo/select/no-autocomplete-demo.ts 71.42% <62.5%> (ø)
src/app/demo/select/multiple-demo.ts 66.66% <63.63%> (ø)
src/app/demo/select-section.ts 69.23% <69.23%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aee01c...d15d6ce. Read the comment docs.

@prikryl prikryl mentioned this pull request Oct 30, 2018
Closed
@optimistex
Copy link

Merged into the fork: https://github.com/optimistex/ngx-select-ex

@gagandeepp
Copy link

IS this still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@prikryl @optimistex @gagandeepp @sibiraj-s @amiram @ert78gb @oscarlocatelli