refactor(position)!: fix spelling mistake #6739
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would seem like there was a typo in the function name `getViewportOffsetRectRelativeToArtbitraryNode` which appears like it should be `getViewportOffsetRectRelativeToArbitraryNode`. BREAKING CHANGE: The `getViewportOffsetRectRelativeToArtbitraryNode` function has been renamed to `getViewportOffsetRectRelativeToArbitraryNode`. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/fix-spelling
branch
from
59b4b1f to
7645380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a spelling mistake, renaming
getViewportOffsetRectRelativeToArtbitraryNodetogetViewportOffsetRectRelativeToArbitraryNode(note the missingtin 'Arbitrary').Breaking Change
The
getViewportOffsetRectRelativeToArtbitraryNodefunction has been renamed togetViewportOffsetRectRelativeToArbitraryNode.PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.
I could not find any mention to that function in the last three points
Note to Reviewers
I have marked this as a breaking change in case the function is exported publicly and/or intended to be used by downstream libraries. Having said that, it seems like this function is only used internally, so I'll leave it up to you to determine whether this qualifies as a breaking change or not.