fix(datepicker): share PositioningService instance #6775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a single shared PositioningService instance for the datepicker and daterangepicker directives to fix adaptive positioning issues: - Adaptive positioning on the daterangepicker now works. - Adaptive positioning on one datepicker no longer affects other instances. - Also apply this change to the inline datepicker and inline daterangepicker for consistency. Fixes valor-software#6773, fixes valor-software#6774
|
Hi @lexasq 👋 |
|
@haryasa looks pretty understandable so far, thanks! |
lexasq
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a single shared PositioningService instance for the datepicker and daterangepicker directives to fix adaptive positioning issues:
Fixes #6773, fixes #6774
Adaptive positioning on the daterangepicker now works
Before:
Screencast.from.2025-09-09.10-09-50.webm
After:
Screencast.from.2025-09-09.10-15-34.webm
Adaptive positioning on one datepicker no longer affects other instances
Before:
Screencast.from.2025-09-09.10-12-12.webm
After:
Screencast.from.2025-09-09.10-17-27.webm
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.