linux: fix readlinkat signed error handling and add regression test#71
Merged
fwsGonzo merged 2 commits intovarnish:masterfrom Apr 22, 2026
Merged
Conversation
fwsGonzo
requested changes
Apr 21, 2026
Member
fwsGonzo
left a comment
There was a problem hiding this comment.
The new std::vector on the heap is <= PATH_MAX in size, and is just more costly than a fixed-size PATH_MAX buffer. I think we will keep the fixed-size buffer and read the link contents into that.
Contributor
Author
|
Agreed. I have made that adjustment. |
fwsGonzo
approved these changes
Apr 22, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This bug is independently valuable to fix and was discovered while working relocation test lanes.
Validation
Notes
This is intentionally standalone and separated from relocation/test-gating work.